Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align LOG_* messages with the upstream style - remove trailing punctuation #1212

Open
JanMatCodasip opened this issue Jan 23, 2025 · 0 comments
Open

Align LOG_* messages with the upstream style - remove trailing punctuation #1212

JanMatCodasip opened this issue Jan 23, 2025 · 0 comments
Labels
Good First Issue This label marks the first good issue for anyone willing to contribute to the project.

Comments

@JanMatCodasip
Copy link
Collaborator

JanMatCodasip commented Jan 23, 2025 •
edited
Loading

The upstream OpenOCD style asks that log messages (printed by LOG_* and LOG_TARGET_* macros) do not end with any punctuation mark like . or !.

See the C Style Guide which says: Do not use a period or exclamation mark at the end of a message.

The task is to:

  • Remove the trailing punctuation in all log messages in src/target/riscv/*,
  • except for messages that consist of multiple sentences.
@JanMatCodasip JanMatCodasip added the Good First Issue This label marks the first good issue for anyone willing to contribute to the project. label Jan 23, 2025
@JanMatCodasip JanMatCodasip changed the title Align LOG_* messages with the upstream style requirements Align LOG_* messages with the upstream style - remove trailing punctuation Jan 23, 2025
@JanMatCodasip JanMatCodasip mentioned this issue Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue This label marks the first good issue for anyone willing to contribute to the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JanMatCodasip