Skip to content

Conversation

@spyteric
Copy link

Add an optional parameter ExpectContinue in constructor, let user decide the server return Continue(100) before success or not.

@risdenk
Copy link
Owner

risdenk commented Oct 19, 2018

What about defaulting the ExpectContinue parameter to false automatically? You should be able to try this by making your own HTTPClient.

Something like forcing this:

_httpClient.DefaultRequestHeaders.ExpectContinue = False

@spyteric
Copy link
Author

So change the parameter of WebHDFSClient 's constructor to

bool ExpectContinue = false

instead of

bool? ExpectContinue = null

And _httpClient is create inside the constructor,
Could I make my own _httpClient?

@risdenk
Copy link
Owner

risdenk commented Oct 20, 2018

I think we can just hardcode the ExpectContinue = false and not have it as a constructor parameter at all. I thought that httpClient was exposed as a constructor argument but I was mistaken. I'm hoping that a one line change in total would fix this issue. I don't think we need to make ExpectContinue user configurable.

@spyteric
Copy link
Author

So, add bool ExpectContinue = true into constuctor as default.
and PR again?
In my case, server will do return "continue 100" before success.

@risdenk
Copy link
Owner

risdenk commented Oct 23, 2018

Does the server still return continue 100 even if the ExpectContinue = False?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants