Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Reuse connector WITH parameters #11545

Closed
xxchan opened this issue Aug 8, 2023 — with Slack · 6 comments
Closed

Feature request: Reuse connector WITH parameters #11545

xxchan opened this issue Aug 8, 2023 — with Slack · 6 comments

Comments

Copy link
Member

xxchan commented Aug 8, 2023

(requested by a user)

e.g., for PostgreSQL CDC, users need to repeatedly enter hostname, port, username, password, ... for all tables. It might be better if there are some ways to reuse the common parameters.

At the same time, are there any existing workarounds?

@github-actions github-actions bot added this to the release-1.2 milestone Aug 8, 2023
@fuyufjh
Copy link
Member

fuyufjh commented Aug 8, 2023

For CDC sources, @StrikeW is working on RFC: Share a change log stream for multiple CDC tables (@StrikeW Please help migrate this doc to RFC repo), which introduces a new syntax to define multiple tables from one upstream DB.

For other things, we don't have a solution yet. Welcome for any discussions & proposals.

@tabVersion
Copy link
Contributor

e.g., for PostgreSQL CDC, users need to repeatedly enter hostname, port, username, password, ... for all tables. It might be better if there are some ways to reuse the common parameters.

actually, I have proposed the connection syntax for this case, risingwavelabs/rfcs#35 but we only adopt the private link part. Maybe it is time to review the design.

@xxchan
Copy link
Member Author

xxchan commented Aug 11, 2023

BTW, I also feel that this request is somewhat similar to #10151, where code reusability is wanted, instead of a new "capability".

One typical argument is that we can simply use global string substitution, or dbt macros.

@ly9chee
Copy link
Contributor

ly9chee commented Aug 15, 2023

I'm also interested in this feature, repeatedly enter hostname, port, username, password is not just verbose and it may cause sensitive information leaks. crdb provides the create external connection syntax that allows you to encapsulate network and authentication settings into a connection object. a user with higher privileges (such as root) can manage these connections by defining the necessary connection parameters. Once the connection object is created, normal users can reference it to create sources and sinks without needing to specify the network and authentication settings each time, also normal users cannot extract any sensitive information from the connection object without grants.

Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@StrikeW StrikeW removed their assignment Oct 21, 2024
@StrikeW
Copy link
Contributor

StrikeW commented Oct 21, 2024

We will introduce Connection to support this feature. close as stale.

@StrikeW StrikeW closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants