Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate standalone into risedev #16601

Open
2 tasks
kwannoel opened this issue May 7, 2024 · 8 comments
Open
2 tasks

Integrate standalone into risedev #16601

kwannoel opened this issue May 7, 2024 · 8 comments
Assignees
Labels
good first issue Good for newcomers help wanted Issues that need help from contributors priority/low type/feature

Comments

@kwannoel
Copy link
Contributor

kwannoel commented May 7, 2024

Unify it, so we can use risedev profile to configure and use it.

  • Add it to risedev, as a profile.
  • Generate its dashboard and prometheus configurations and commit them.
Copy link
Contributor

github-actions bot commented Jul 8, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@fuyufjh
Copy link
Member

fuyufjh commented Jul 10, 2024

Shall we close this?

@fuyufjh fuyufjh removed this from the release-1.10 milestone Jul 10, 2024
@BugenZhao
Copy link
Member

Is this for testing purposes?

@kwannoel
Copy link
Contributor Author

It's not really necessary, but I think it's a good improvement. Currently the way the cluster is started is rather manual for standalone mode. Still need to pass in the parameters. We should just use risedev to manage it instead.

@BugenZhao
Copy link
Member

In my opinion, I think it'll be nice if we can simply add a flag to use standalone mode to start multiple services in the same process for existing profiles, achieving the goal of enhancing the coverage of the standalone mode without introduction of new services or profiles. However, this might require some refactoring in RiseDev, given that all services are independently started in its own tmux panel in current implementation.

@kwannoel kwannoel added the good first issue Good for newcomers label Oct 23, 2024
@kwannoel kwannoel added the help wanted Issues that need help from contributors label Oct 23, 2024
@kwannoel
Copy link
Contributor Author

In my opinion, I think it'll be nice if we can simply add a flag to use standalone mode to start multiple services in the same process for existing profiles, achieving the goal of enhancing the coverage of the standalone mode without introduction of new services or profiles. However, this might require some refactoring in RiseDev, given that all services are independently started in its own tmux panel in current implementation.

You can take a try using this approach @wcy-fdu

@BugenZhao
Copy link
Member

May I know the updates on the motivation of this task?

@kwannoel
Copy link
Contributor Author

kwannoel commented Oct 28, 2024

May I know the updates on the motivation of this task?

Currently the way the standalone service is managed in ci is rather adhoc:

if [[ $mode == "standalone" ]]; then
mkdir -p "$PREFIX_LOG"
risedev clean-data
risedev pre-start-dev
risedev dev standalone-minio-sqlite &
PID=$!
sleep 1
start_standalone "$PREFIX_LOG"/standalone.log &
wait $PID

It can lead to breakage in ci (see: #19067). If we support standalone in risedev, we can properly sequence the startup of its services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Issues that need help from contributors priority/low type/feature
Projects
None yet
Development

No branches or pull requests

4 participants