Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(batch): restarted serving node occasionally doesn't bump up min_pinned_hummock_version #19050

Open
zwang28 opened this issue Oct 22, 2024 · 2 comments
Assignees
Labels
type/bug Something isn't working
Milestone

Comments

@zwang28
Copy link
Contributor

zwang28 commented Oct 22, 2024

Describe the bug

  1. A serving node coexists with a frontend node in the same RisingWave standalone process in a pod.
  2. Restart the pod.
  3. The min_pinned_hummock_version held by this serving node is no longer increasing, unexpectedly. This is the issue.
    • show processlist returns no records.
  4. The min_pinned_hummock_version starts to increase due to forceful expiration after max_version_pinning_duration_sec.

Error message/log

No response

To Reproduce

No response

Expected behavior

No response

How did you deploy RisingWave?

No response

The version of RisingWave

v1.10

Additional context

No response

@zwang28 zwang28 added the type/bug Something isn't working label Oct 22, 2024
@github-actions github-actions bot added this to the release-2.2 milestone Oct 22, 2024
@zwang28 zwang28 self-assigned this Oct 22, 2024
@kwannoel
Copy link
Contributor

kwannoel commented Nov 7, 2024

Restart the pod.

So after pod restarts, somehow after its comes back online, it continues to hold the same min_pinned_hummock_version. Which suggests this is persisted somewhere.

Where do we pin the hummock version, is it managed by meta / serving / frontend?

@zwang28
Copy link
Contributor Author

zwang28 commented Nov 7, 2024

Restart the pod.

So after pod restarts, somehow after its comes back online, it continues to hold the same min_pinned_hummock_version. Which suggests this is persisted somewhere.

Where do we pin the hummock version, is it managed by meta / serving / frontend?

Each compute node holds a min_pinned_hummock_version, which is persisted in meta node.
The compute node is expected to bump it up periodically.

I suspect the issue arises from the scan executor in the serving node not being properly canceled after a frontend restart.

  1. The frontend schedules execution in serving node.
  2. The frontend restarts. Howevert the scheduled execution in serving node is not cancelled accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants