Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source_rate_limit doesn't work for file source #19296

Open
xxchan opened this issue Nov 7, 2024 · 1 comment
Open

source_rate_limit doesn't work for file source #19296

xxchan opened this issue Nov 7, 2024 · 1 comment
Labels
type/bug Something isn't working
Milestone
release-2.2

Comments

@xxchan
Copy link
Member

xxchan commented Nov 7, 2024 •
edited
Loading

Describe the bug

FsFetch is not handled in update_source_rate_limit_by_source_id

Error message/log

No response

To Reproduce

Add source_rate_limit = 0 in e2e_test/source_inline/fs/posix_fs.slt, you can see data still produced

Expected behavior

No response

How did you deploy RisingWave?

No response

The version of RisingWave

No response

Additional context

No response
@xxchan xxchan added the type/bug Something isn't working label Nov 7, 2024
@github-actions github-actions bot added this to the release-2.2 milestone Nov 7, 2024
@kwannoel
Copy link
Contributor

kwannoel commented Nov 7, 2024 •
edited
Loading

What's the corresponding streaming source executor for it? Is it the fetch_executor?

Edit: Yes it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Something isn't working
Projects
None yet
Milestone
release-2.2
Development

No branches or pull requests
2 participants
@xxchan @kwannoel