Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cyclic dependency edge case with the R2API core #483

Open
xiaoxiao921 opened this issue Jun 3, 2023 · 0 comments
Open

Small cyclic dependency edge case with the R2API core #483

xiaoxiao921 opened this issue Jun 3, 2023 · 0 comments

Comments

@xiaoxiao921
Copy link
Member

xiaoxiao921 commented Jun 3, 2023

most modules have a package ref csproj dependency on r2api.core, but no attribute bepindependency on it, meaning that potentially the logger (only this so far) could be used (through on the of public methods for example) while the Awake() still not being fired, leading to exceptions

a solution to this if i'm not mistaken would just be to move the logger to a r2apicore baseunityplugin class and have the r2api baseunityplugin depends on it, while making sure the r2api submodules which depends on Core have a bepindependency on it

the modules can't have a bepindependency on r2api baseunityplugin as this one already happens to have soft dependencies to most of them, due to it being the r2api.legacy baseunityplugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant