Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorsAPI hooks are broken #516

Closed
xiaoxiao921 opened this issue Jan 10, 2024 · 1 comment · Fixed by #554
Closed

ColorsAPI hooks are broken #516

xiaoxiao921 opened this issue Jan 10, 2024 · 1 comment · Fixed by #554
Labels
bug Something isn't working

Comments

@xiaoxiao921
Copy link
Member

user state:

Add a color to the Color Catalog so I can set the color of my tier in game to be a custom color
Also, turns out it IS returning the error ColorIndex. Which makes me think that the hooks are getting unset somewhere
I made my own Utils that basically copies ColorsAPI exactly, but instead of using IL hooks, I use On hooks and it works

@Nebby1999
Copy link
Contributor

i know for a fact that at least the damage color index immplementation does work, so this might be related specifically to the regular color indices.

I say this because ss2 uses colorsAPI's damage color implementation and it works just fine.

@xiaoxiao921 xiaoxiao921 added the bug Something isn't working label Jun 2, 2024
@xiaoxiao921 xiaoxiao921 linked a pull request Oct 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants