Skip to content

Commit 0e09b85

Browse files
committed
Updates docs.
1 parent 17f6a42 commit 0e09b85

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,6 @@ So far we have created 6 modules as ERC proposals, all of which are ERC721 compa
3333
- Soulbound: [ERC-6454: Minimal Transferable NFT detection interface](https://eips.ethereum.org/EIPS/eip-6454)
3434
- Emotable: [ERC-7409: Public Non-Fungible Tokens Emote Repository](https://eips.ethereum.org/EIPS/eip-7409)
3535
- Dynamic Attributes: [ERC-7508: Dynamic On-Chain Token Attributes Repository ](https://eips.ethereum.org/EIPS/eip-7508)
36+
- ERC20-Holder: [ERC-7590: ERC-20 Holder Extension for NFTs ](https://eips.ethereum.org/EIPS/eip-7590)
3637

3738
![RMRK Modules](/img/General_Overview_Modules.png)

contracts/RMRK/extension/tokenHolder/IERC7590.sol

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// SPDX-License-Identifier: Apache-2.0
1+
// SPDX-License-Identifier: CC0-1.0
22

33
pragma solidity ^0.8.21;
44

@@ -47,8 +47,8 @@ interface IERC7590 is IERC165 {
4747
/**
4848
* @notice Transfer ERC-20 tokens from a specific token.
4949
* @dev The balance MUST be transferred from this smart contract.
50-
* @dev Implementers should validate that the `msg.sender` is either the token owner or approved to manage it before calling this.
51-
* @dev Must increase the transfer-out-nonce for the tokenId
50+
* @dev MUST increase the transfer-out-nonce for the tokenId
51+
* @dev MUST revert if the `msg.sender` is not the owner of the NFT or approved to manage it.
5252
* @param erc20Contract The address of the ERC-20 smart contract
5353
* @param tokenId The ID of the token to transfer the ERC-20 tokens from
5454
* @param amount The number of ERC-20 tokens to transfer

docs/RMRK/extension/tokenHolder/IERC7590.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ function transferHeldERC20FromToken(address erc20Contract, uint256 tokenId, addr
104104

105105
Transfer ERC-20 tokens from a specific token.
106106

107-
*The balance MUST be transferred from this smart contract.Implementers should validate that the `msg.sender` is either the token owner or approved to manage it before calling this.Must increase the transfer-out-nonce for the tokenId*
107+
*The balance MUST be transferred from this smart contract.MUST increase the transfer-out-nonce for the tokenIdMUST revert if the `msg.sender` is not the owner of the NFT or approved to manage it.*
108108

109109
#### Parameters
110110

docs/RMRK/extension/tokenHolder/RMRKTokenHolder.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ function transferHeldERC20FromToken(address erc20Contract, uint256 tokenId, addr
104104

105105
Transfer ERC-20 tokens from a specific token.
106106

107-
*The balance MUST be transferred from this smart contract.Implementers should validate that the `msg.sender` is either the token owner or approved to manage it before calling this.Must increase the transfer-out-nonce for the tokenId*
107+
*The balance MUST be transferred from this smart contract.MUST increase the transfer-out-nonce for the tokenIdMUST revert if the `msg.sender` is not the owner of the NFT or approved to manage it.*
108108

109109
#### Parameters
110110

0 commit comments

Comments
 (0)