Ok, since we are going to store metadata for multiple entities(Nfts, Collections, Bases, Parts) we might want to do something like the following so that we avoid code duplication.

// define an enum that will have all of the mentioned entities that will store metadata
enum Entity<T: Config> {
        /// The entity is a collection
        Collection(T::CollectionId),
	/// The entity is a collection nft
	Nft(T::CollectionId, T::ItemId),
	/// The entity is a base
	Base(BaseId), 
        /// The entity is a Part
        Part(PartId),
}

// --snip--
#[pallet::call_index(9)]
#[pallet::weight(<T as pallet::Config>::WeightInfo::set_property())]
#[transactional]
pub fn set_property(
	origin: OriginFor<T>,
	entity: Entity<T>,
	key: KeyLimitOf<T>,
	value: ValueLimitOf<T>,
) -> DispatchResult {
        let sender = ensure_signed(origin)?;

	Self::property_set(sender, collection_id, maybe_nft_id, key.clone(), value.clone())?;

	Self::deposit_event(Event::PropertySet { collection_id, maybe_nft_id, key, value });
	Ok(())
}
// --snip--

And then inside functions.rs we implement custom logic for every type.

@ilionic @HashWarlock Do you think this makes sense?

Adding Metadata to Base #270

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions