perf: Missing node_parent_position composite index

Author: roadiz-ci

src/AjaxControllers/AjaxAttributeValuesController.php

@@ -64,17 +64,17 @@ public function editAction(Request $request, int $attributeValueId): Response
     }
 
     /**
-     * @param array         $parameters
+     * @param array $parameters
      * @param AttributeValue $attributeValue
      *
      * @return array
      */
-    protected function updatePosition($parameters, AttributeValue $attributeValue): array
+    protected function updatePosition(array $parameters, AttributeValue $attributeValue): array
     {
         $attributable = $attributeValue->getAttributable();
         $details = [
             '%name%' => $attributeValue->getAttribute()->getLabelOrCode(),
-            '%nodeName%' => $attributable instanceof Node ? $attributable->getNodeName() : '',
+            '%nodeName%' => $attributable->getNodeName(),
         ];
         /*
          * First, we set the new parent

src/Forms/NodeType.php

@@ -31,7 +31,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
 
         /** @var Node|null $node */
         $node = $builder->getData();
-        $isReachable = null !== $node && $node->getNodeType()?->isReachable();
+        $isReachable = null !== $node && $node->getNodeType()->isReachable();
         if ($isReachable) {
             $builder->add('home', CheckboxType::class, [
                 'label' => 'node.isHome',

src/Models/NodeModel.php

@@ -37,7 +37,7 @@ public function toArray(): array
                 'nodeName' => $this->node->getNodeName(),
                 'isPublished' => $this->node->isPublished(),
                 'nodeType' => [
-                    'color' => $this->node->getNodeType()?->getColor() ?? '#000000',
+                    'color' => $this->node->getNodeType()->getColor() ?? '#000000',
                 ]
             ];
             if ($this->security->isGranted(NodeVoter::EDIT_SETTING, $this->node)) {
@@ -60,7 +60,7 @@ public function toArray(): array
             'nodeName' => $this->node->getNodeName(),
             'isPublished' => $this->node->isPublished(),
             'nodeType' => [
-                'color' => $this->node->getNodeType()?->getColor() ?? '#000000',
+                'color' => $this->node->getNodeType()->getColor() ?? '#000000',
             ]
         ];
 

src/Models/NodeSourceModel.php

@@ -40,7 +40,7 @@ public function toArray(): array
             'thumbnail' => $thumbnail ? $thumbnail->getDocument() : null,
             'isPublished' => $node->isPublished(),
             'nodeType' => [
-                'color' => $node->getNodeType()?->getColor() ?? '#000000',
+                'color' => $node->getNodeType()->getColor() ?? '#000000',
             ]
         ];