Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the whole response instead of just the response["data"] in getData(). #3

Open
sarthak-patidar opened this issue May 30, 2019 · 1 comment

Comments

@sarthak-patidar
Copy link

Can you modify this library to return the whole response object instead of just the data key of the response (on line 128 of phpCriclib.php)?
This way users can access the etag (to enable etag based caching which ultimately saves your bandwidth and allows users to optimize their platform) and status codes (to re-pull in case of non 200 response code)

@suganyaudhay
Copy link

Thanks for your wonderful suggestion. We decided to implement the requested changes on the library. I'll let you know once it done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants