From 255fc833827553aa9f36deb844d8b0e7b7f59fd8 Mon Sep 17 00:00:00 2001 From: Leo Robinovitch Date: Sat, 1 Feb 2025 09:24:12 -0800 Subject: [PATCH] trim trailing space from log content --- internal/model/k8s_log.go | 2 ++ internal/viewport/viewport.go | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/internal/model/k8s_log.go b/internal/model/k8s_log.go index 359bdba..53174a7 100644 --- a/internal/model/k8s_log.go +++ b/internal/model/k8s_log.go @@ -9,6 +9,7 @@ import ( "github.com/robinovitch61/kl/internal/viewport/linebuffer" "strings" "time" + "unicode" ) type Log struct { @@ -58,6 +59,7 @@ func (ls LogScanner) StartReadingLogs() { logContent := strings.Join(vals[1:], " ") logContent = strings.ReplaceAll(logContent, "\t", " ") + logContent = strings.TrimRightFunc(logContent, unicode.IsSpace) // precompute LogData here as logs come in as logs are immutable. Having the LogData up front helps // to minimize expensive/repeated re-computation later diff --git a/internal/viewport/viewport.go b/internal/viewport/viewport.go index ab496be..a082d84 100644 --- a/internal/viewport/viewport.go +++ b/internal/viewport/viewport.go @@ -717,7 +717,7 @@ func (m Model[T]) getVisibleContentLines() visibleContentLinesResult { } if m.wrapText { - lb := currItem.Render() // TODO LEO: strings.TrimRightFunc(currItem.String(), unicode.IsSpace), m.width + lb := currItem.Render() itemLines := lb.WrappedLines(m.width, m.height, m.stringToHighlight, m.highlightStyle(currItemIdx)) offsetLines := safeSliceFromIdx(itemLines, m.topItemLineOffset) done = addLines(linebuffer.ToLineBuffers(offsetLines), currItemIdx) @@ -728,7 +728,7 @@ func (m Model[T]) getVisibleContentLines() visibleContentLinesResult { done = true } else { currItem = m.allItems[currItemIdx] - lb = currItem.Render() // TODO LEO: strings.TrimRightFunc(currItem.String(), unicode.IsSpace), m.width + lb = currItem.Render() itemLines = lb.WrappedLines(m.width, m.height, m.stringToHighlight, m.highlightStyle(currItemIdx)) done = addLines(linebuffer.ToLineBuffers(itemLines), currItemIdx) }