-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KeyPoints] - KeyPoints
doesn't work like Detections
filtering
#1437
Comments
@SkalskiP do we want to filter "keypoint" group (ex: I have 7 detected humans I want to filter last 4 human keypoints and left other 3 humans based on filter) or just points itself because filtering points itself visually can break. Also in case of "shortages" should we fill values in something like negative values for prevents np.newaxis change requirement |
@onuralpszr At which point would the newaxis cause issues? Would one of the dimensions collapse? |
My thinking was, Not using "newaxis" at all case and also curious about solution because we also talked about this in earlier how to manage because "filtering points" cause issue also key points can be incomplete (half body detection or semi visible cases) |
I see your points. Filtering is ultimately a skeleton-level operation and is almost guaranteed to invalidate a |
To prevent that "we need" some sort of fillers because I need them all same but don't do anything, Because in picture It could be okay but in videos I can see problems like "occlusions" would be first. |
@SkalskiP Shouldn't the class_id, confidence and class_name have the same shape as xy.shape[:2] and shouldn't they be arrays for keypoints detected for each object. |
Bug
When trying to filter
KeyPoints
byconfidence
like this:I get this:
This is a symptom of a much broader problem - the
KeyPoints
object does not allow the skeleton of different objects to have different lengths.I managed to work around this problem like this, but it's a very hacky solution.
Additional
The text was updated successfully, but these errors were encountered: