Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update defaultStore to return instancetype? #215

Open
chadpod opened this issue Sep 22, 2017 · 0 comments
Open

Update defaultStore to return instancetype? #215

chadpod opened this issue Sep 22, 2017 · 0 comments

Comments

@chadpod
Copy link

chadpod commented Sep 22, 2017

Wondering what your thoughts are on updating

+ (RMStore *)defaultStore

to be

+ (instancetype)defaultStore

and changing sharedInstance to id?

Allows RMStore to be easily subclassed. We initially had a category on RMStore adding some of our own stuff, but I also wanted to easily store some state on it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chadpod