Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wholeBodyDynamics configuration files for ergoCubSN00* not setting the estimateJointVelocityAcceleration option? #668

Closed
traversaro opened this issue Jul 10, 2024 · 1 comment · Fixed by #677

Comments

@traversaro
Copy link
Member

traversaro commented Jul 10, 2024

While working on robotology/whole-body-estimators#194 , I noticed that the test was printing a warning:

[WARNING] wholeBodyDynamics: estimateVelocityAccelerationOptionName bool parameter missing, please specify it.";
[WARNING] wholeBodyDynamics: setting estimateVelocityAccelerationOptionName to the default value of true, but this is a deprecated behaviour that will be removed in the future.";

that was surprising for me, as I based the test introduced in robotology/whole-body-estimators#177 on the configurations of ergoCubSN00* . Indeed, by looking in the configuration files for ergoCubSN00*, I noticed that the estimateJointVelocityAcceleration option is never set (the error refers to a different name, but it is a typo).

This means that for ergoCubSN00 torque estimation we never used the velocity estimated at low level, but always the velocity estimated at high level with a kalman filter.*

I guess we should get rid of this warning by explicitly setting estimateJointVelocityAcceleration (as done for iCub3 in

<param name="estimateJointVelocityAcceleration">false</param> <!-- if true a kf will estimate the joint velocities and accelerations -->
) and then we can modify wbd to raise an error if the parameter is not set.

fyi @GiulioRomualdi @isorrentino @LoreMoretti

@traversaro
Copy link
Member Author

Actually as noticed by @S-Dafarra actually the default value is false, so we should be good to go, see https://github.com/robotology/whole-body-estimators/pull/194/files#r1673528015 . However, I think we should anyhow set the parameter explicitly to silence the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant