From 5c368292eed496d3099bb6055056559d4cd01f6f Mon Sep 17 00:00:00 2001 From: Silvio Traversaro Date: Fri, 6 Dec 2024 14:22:20 +0100 Subject: [PATCH 1/3] Use modern iDynTree header inclusions to avoid deprecation warnings --- .github/CONTRIBUTING.md | 4 ++-- toolbox/base/src/RobotInterface.cpp | 6 +++--- toolbox/base/src/WBBlock.cpp | 10 +++++----- toolbox/library/src/CentroidalMomentum.cpp | 4 ++-- .../library/src/CentroidalTotalMomentumMatrix.cpp | 8 ++++---- toolbox/library/src/DotJNu.cpp | 6 +++--- toolbox/library/src/ForwardKinematics.cpp | 6 +++--- toolbox/library/src/GetLimits.cpp | 6 +++--- toolbox/library/src/InverseDynamics.cpp | 14 +++++++------- toolbox/library/src/InverseKinematics.cpp | 2 +- toolbox/library/src/Jacobian.cpp | 8 ++++---- toolbox/library/src/MassMatrix.cpp | 4 ++-- toolbox/library/src/RelativeJacobian.cpp | 8 ++++---- toolbox/library/src/RelativeTransform.cpp | 6 +++--- 14 files changed, 46 insertions(+), 46 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 2275ab41c..28c273917 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -60,8 +60,8 @@ Example: #include "RobotInterface.h" #include "Signal.h" -#include -#include +#include +#include #include #include diff --git a/toolbox/base/src/RobotInterface.cpp b/toolbox/base/src/RobotInterface.cpp index f514ce82e..80a28b0b3 100644 --- a/toolbox/base/src/RobotInterface.cpp +++ b/toolbox/base/src/RobotInterface.cpp @@ -11,9 +11,9 @@ #include #include -#include -#include -#include +#include +#include +#include #include #include #include diff --git a/toolbox/base/src/WBBlock.cpp b/toolbox/base/src/WBBlock.cpp index 9c9c55f7a..bccc1d0b6 100644 --- a/toolbox/base/src/WBBlock.cpp +++ b/toolbox/base/src/WBBlock.cpp @@ -16,11 +16,11 @@ #include #include #include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include #include #include diff --git a/toolbox/library/src/CentroidalMomentum.cpp b/toolbox/library/src/CentroidalMomentum.cpp index 36bd0dcd3..a7bcf9929 100644 --- a/toolbox/library/src/CentroidalMomentum.cpp +++ b/toolbox/library/src/CentroidalMomentum.cpp @@ -13,8 +13,8 @@ #include #include #include -#include -#include +#include +#include #include #include diff --git a/toolbox/library/src/CentroidalTotalMomentumMatrix.cpp b/toolbox/library/src/CentroidalTotalMomentumMatrix.cpp index 41eccf660..bd90368e5 100644 --- a/toolbox/library/src/CentroidalTotalMomentumMatrix.cpp +++ b/toolbox/library/src/CentroidalTotalMomentumMatrix.cpp @@ -16,11 +16,11 @@ #include #include #include -#include -#include -#include +#include +#include +#include #include -#include +#include #include #include diff --git a/toolbox/library/src/DotJNu.cpp b/toolbox/library/src/DotJNu.cpp index 1a4980c41..0be4bddea 100644 --- a/toolbox/library/src/DotJNu.cpp +++ b/toolbox/library/src/DotJNu.cpp @@ -15,10 +15,10 @@ #include #include #include -#include -#include +#include +#include #include -#include +#include #include #include diff --git a/toolbox/library/src/ForwardKinematics.cpp b/toolbox/library/src/ForwardKinematics.cpp index aa9365fb0..796eb8819 100644 --- a/toolbox/library/src/ForwardKinematics.cpp +++ b/toolbox/library/src/ForwardKinematics.cpp @@ -16,10 +16,10 @@ #include #include #include -#include -#include +#include +#include #include -#include +#include #include #include diff --git a/toolbox/library/src/GetLimits.cpp b/toolbox/library/src/GetLimits.cpp index 72a26ff68..50f44ed4f 100644 --- a/toolbox/library/src/GetLimits.cpp +++ b/toolbox/library/src/GetLimits.cpp @@ -16,9 +16,9 @@ #include #include #include -#include -#include -#include +#include +#include +#include #include #include diff --git a/toolbox/library/src/InverseDynamics.cpp b/toolbox/library/src/InverseDynamics.cpp index 2d2cc80c4..d7ee2221e 100644 --- a/toolbox/library/src/InverseDynamics.cpp +++ b/toolbox/library/src/InverseDynamics.cpp @@ -14,14 +14,14 @@ #include #include #include -#include -#include -#include -#include +#include +#include +#include +#include #include -#include -#include -#include +#include +#include +#include #include #include diff --git a/toolbox/library/src/InverseKinematics.cpp b/toolbox/library/src/InverseKinematics.cpp index 661a06900..031ae8d86 100644 --- a/toolbox/library/src/InverseKinematics.cpp +++ b/toolbox/library/src/InverseKinematics.cpp @@ -7,7 +7,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/toolbox/library/src/Jacobian.cpp b/toolbox/library/src/Jacobian.cpp index d9526e8af..4bca9a15c 100644 --- a/toolbox/library/src/Jacobian.cpp +++ b/toolbox/library/src/Jacobian.cpp @@ -16,11 +16,11 @@ #include #include #include -#include -#include -#include +#include +#include +#include #include -#include +#include #include #include diff --git a/toolbox/library/src/MassMatrix.cpp b/toolbox/library/src/MassMatrix.cpp index 3e48f1ceb..a9472cfae 100644 --- a/toolbox/library/src/MassMatrix.cpp +++ b/toolbox/library/src/MassMatrix.cpp @@ -14,8 +14,8 @@ #include #include #include -#include -#include +#include +#include #include #include diff --git a/toolbox/library/src/RelativeJacobian.cpp b/toolbox/library/src/RelativeJacobian.cpp index a2d5463ca..5e52a7167 100644 --- a/toolbox/library/src/RelativeJacobian.cpp +++ b/toolbox/library/src/RelativeJacobian.cpp @@ -16,11 +16,11 @@ #include #include #include -#include -#include -#include +#include +#include +#include #include -#include +#include #include #include diff --git a/toolbox/library/src/RelativeTransform.cpp b/toolbox/library/src/RelativeTransform.cpp index e7e2c0947..fefca0420 100644 --- a/toolbox/library/src/RelativeTransform.cpp +++ b/toolbox/library/src/RelativeTransform.cpp @@ -16,10 +16,10 @@ #include #include #include -#include -#include +#include +#include #include -#include +#include #include From 4abd314a626934f7457f9795a2c5d68509ed0451 Mon Sep 17 00:00:00 2001 From: Silvio Traversaro Date: Fri, 6 Dec 2024 14:27:25 +0100 Subject: [PATCH 2/3] Do not link idyntree-modelio-urdf but link idyntree-modelio and update ModelIO header inclusions --- toolbox/base/CMakeLists.txt | 2 +- toolbox/base/src/RobotInterface.cpp | 2 +- toolbox/library/CMakeLists.txt | 2 +- toolbox/library/src/InverseKinematics.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/toolbox/base/CMakeLists.txt b/toolbox/base/CMakeLists.txt index 8eb4c15b2..4376f1d8f 100644 --- a/toolbox/base/CMakeLists.txt +++ b/toolbox/base/CMakeLists.txt @@ -24,7 +24,7 @@ target_link_libraries(WBToolboxBase YARP::YARP_init YARP::YARP_dev iDynTree::idyntree-model - iDynTree::idyntree-modelio-urdf + iDynTree::idyntree-modelio iDynTree::idyntree-high-level) target_include_directories(WBToolboxBase PUBLIC diff --git a/toolbox/base/src/RobotInterface.cpp b/toolbox/base/src/RobotInterface.cpp index 80a28b0b3..db995066a 100644 --- a/toolbox/base/src/RobotInterface.cpp +++ b/toolbox/base/src/RobotInterface.cpp @@ -14,7 +14,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/toolbox/library/CMakeLists.txt b/toolbox/library/CMakeLists.txt index aeba0b852..d0784adf8 100644 --- a/toolbox/library/CMakeLists.txt +++ b/toolbox/library/CMakeLists.txt @@ -101,7 +101,7 @@ list(APPEND WBTOOLBOXLIBRARY_EXT_LIBRARIES YARP::YARP_math iDynTree::idyntree-core iDynTree::idyntree-model - iDynTree::idyntree-modelio-urdf + iDynTree::idyntree-modelio iDynTree::idyntree-high-level) # Additional dependency of the SimulatorSynchronizer block diff --git a/toolbox/library/src/InverseKinematics.cpp b/toolbox/library/src/InverseKinematics.cpp index 031ae8d86..4ad5c0d9d 100644 --- a/toolbox/library/src/InverseKinematics.cpp +++ b/toolbox/library/src/InverseKinematics.cpp @@ -8,7 +8,7 @@ #include #include #include -#include +#include #include #include #include From d602ad7d5d47c9f5a92a7d148c6f8d67d964a06c Mon Sep 17 00:00:00 2001 From: Silvio Traversaro Date: Fri, 6 Dec 2024 14:27:48 +0100 Subject: [PATCH 3/3] Bump minimum CMake version to 3.16 to avoid warnings --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 10e25bd8e..4253a96b2 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -2,7 +2,7 @@ # This software may be modified and distributed under the terms of the # GNU Lesser General Public License v2.1 or any later version. -cmake_minimum_required(VERSION 3.5) +cmake_minimum_required(VERSION 3.16) project(WB-Toolbox LANGUAGES CXX VERSION 6.0.0) if(WBT_BUILD_DOCS)