Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template_enricher can't handle label app.kubernetes.io/name #1316

Open
zmx opened this issue Mar 1, 2024 · 4 comments
Open

template_enricher can't handle label app.kubernetes.io/name #1316

zmx opened this issue Mar 1, 2024 · 4 comments

Comments

@zmx
Copy link
Contributor

zmx commented Mar 1, 2024

Describe the bug
K8s Pod create by Argo CD will have label app.kubernetes.io/name
The KubernetesResourceEvent have that label, but string.Template.safe_substitute can't handle dot and slash

To Reproduce

$ kubectl get pod cert-manager-758c6b68ff-v2zwl -n cert-manager -o yaml
apiVersion: v1
kind: Pod
metadata:
  annotations:
    prometheus.io/path: /metrics
    prometheus.io/port: "9402"
    prometheus.io/scrape: "true"
  creationTimestamp: "2023-11-16T22:55:04Z"
  generateName: cert-manager-758c6b68ff-
  labels:
    app: cert-manager
    app.kubernetes.io/component: controller
    app.kubernetes.io/instance: cert-manager
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: cert-manager
    app.kubernetes.io/version: v1.11.2
    azure.workload.identity/use: "true"
    helm.sh/chart: cert-manager-v1.11.2

Expected behavior
template could handle ${app.kubernetes.io/name}

Copy link

github-actions bot commented Mar 1, 2024

Hi 👋, thanks for opening an issue! Please note, it may take some time for us to respond, but we'll get back to you as soon as we can!

  • 💬 Slack Community: Join Robusta team and other contributors on Slack here.
  • 📖 Docs: Find our documentation here.
  • 🎥 YouTube Channel: Watch our videos here.

@zmx
Copy link
Contributor Author

zmx commented Mar 1, 2024

@zmx
Copy link
Contributor Author

zmx commented Jul 21, 2024

looks like resolved by #1389

@zmx
Copy link
Contributor Author

zmx commented Jul 21, 2024

#1492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant