Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to configure nodeSelector and tolerasions for KRR pod on k8s #1442

Closed
AlexLov opened this issue May 27, 2024 · 5 comments
Closed

Comments

@AlexLov
Copy link

AlexLov commented May 27, 2024

Is your feature request related to a problem?
I have KRR pods often killed by OOM in some big clusters (like 3000+ pods) while I can adjust memory request/limit of that pod it also starts on quite packed nodes dedicated for main workload and this adjustments to memory might interfere with it. For some side workloads like monitoring and related staff (like robusta) I have dedicated nodes with enough resources so they won't interfere with main workload even if they consume all the node's resources. I use nodeSelectors and tolerations to run all my services on these dedicated nodes and prevent main cluster's workload to be scheduled there.

Describe the solution you'd like
Please add options to configure nodeSelector and tolerations for KRR job or at least let them to be taken from robusta-runner pod itself.

Describe alternatives you've considered
There are none. I didn't find how to disable KRR pod to be run at all either.

Copy link

Hi 👋, thanks for opening an issue! Please note, it may take some time for us to respond, but we'll get back to you as soon as we can!

  • 💬 Slack Community: Join Robusta team and other contributors on Slack here.
  • 📖 Docs: Find our documentation here.
  • 🎥 YouTube Channel: Watch our videos here.

@aantn
Copy link
Collaborator

aantn commented May 27, 2024

@AlexLov
Copy link
Author

AlexLov commented May 27, 2024

Oh, I somehow overlooked this page :(
Sure it should do the trick for me.
Sorry for inconvenience.

@AlexLov AlexLov closed this as completed May 27, 2024
@aantn
Copy link
Collaborator

aantn commented May 27, 2024

All good! Any idea where you looked in the docs/github? I'll make sure we add a link so it is more discoverable.

@AlexLov
Copy link
Author

AlexLov commented May 28, 2024

I looked first into values.yaml of the chart and then in code directly. I checked the docs awhile ago and haven't seen this page (or just didn't go that deep then).
Maybe placing the page above * Troubleshooting pages in the list would help it to be more visible. For me these troubleshooting pages and anything beyond kinda advanced stuff that needed only occasionally so no need to dig deep until really needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants