Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use index map hashing instead of WyHash for MutMap #7531

Open
1 task
Anton-4 opened this issue Jan 18, 2025 · 0 comments
Open
1 task

Use index map hashing instead of WyHash for MutMap #7531

Anton-4 opened this issue Jan 18, 2025 · 0 comments

Comments

@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 18, 2025 •
edited
Loading

We were having issues with this line of code. There was a difference in the order of procs on macos aarch64 vs on linux x64 which lead to differences(failures) in our mono tests. For all uses of MutMap we should use index map hashing instead of wyhash. That should avoid surprise differences in order.
@Anton-4 Anton-4 mentioned this issue Jan 18, 2025
Merged
Anton-4 added a commit that referenced this issue Jan 19, 2025
@Anton-4
Merge pull request #7532 from roc-lang/mono_test_fix
b183ba1 
proc sort fix #7531
@Anton-4 Anton-4 reopened this Jan 19, 2025
@Anton-4 Anton-4 changed the title Use index map hashing instead of WyHash for mono procs Use index map hashing instead of WyHash for MutMap Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Anton-4