-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teach test::Proxy to send packets in reverse direction #772
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@kiranlahiri Feel free to ping me if you'll decide to work on this. For now, unassigning the issue so that someone could pick it up. |
Hi, I’d like to work on this issue! I’ve looked into the Can I be assigned to this? Let me know if there are any specific guidelines for this issue in particular I should follow. Thanks! |
@GabrielPerezCSDev You're welcome, thanks. There are no specific guidelines besides issue text and contributions guidelines in our docs. |
I've implemented the requested changes and submitted a PR: #PR_Number. Summary of Changes:
Let me know if any changes are needed! |
test::Proxy is a class that we use in integration tests for C API.
Proxy is inserted between sender and receiver. Instead of connecting sender to receiver, we connect sender to proxy and proxy to receiver. Mostly, proxy just forwards packets as is and calculates some metrics, but it can also simulate network losses by dropping some packets.
Currently Proxy supports two uni-directional endpoints: one for source packets (audio packets sent from sender to receiver) and another for repair packets (redundancy packets sent from sender to receiver). See docs.
We want to teach Proxy to support optional endpoint for control packets. This endpoint should be bidirectional, i.e. sender sends control packets to receiver (via proxy), and receiver sends control packets to sender (via proxy).
This would allow us to improve tests for metrics.
The text was updated successfully, but these errors were encountered: