Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for parser & composer status codes #792

Open
7 tasks
gavv opened this issue Jan 16, 2025 · 3 comments
Open
7 tasks

Unit tests for parser & composer status codes #792

gavv opened this issue Jan 16, 2025 · 3 comments
Assignees
Labels
easy hacks The solution is expected to be straightforward even if you are new to the project help wanted An important and awaited task but we have no human resources for it yet tests

Comments

@gavv
Copy link
Member

gavv commented Jan 16, 2025

This is a follow-up for #736 and #737.

Add simple tests to check how status codes returned from implementations of IParser and IComposer:

  • Add unit tests for rtp::Parser, rtp::Composer, fec::Parser, fec::Composer for the cases when they return non-OK status.

  • Add unit tests for components that use parsers and composers. In tests, check that the component properly forwards error code from parser/composer to the caller.

    For example, a test makes Composer to fail with StatusNoMem, and check Shipper::write() returns StatusNoMem.

    Classes to cover:

    • fec::BlockReader
    • fec::BlockWriter
    • packet::Shipper
    • audio::Packetizer
    • audio::Depacketizer
@gavv gavv added easy hacks The solution is expected to be straightforward even if you are new to the project help wanted An important and awaited task but we have no human resources for it yet tests labels Jan 16, 2025
@gavv gavv added this to Roc Toolkit Jan 16, 2025
@github-project-automation github-project-automation bot moved this to Frontlog in Roc Toolkit Jan 16, 2025
@gavv gavv moved this from Frontlog to Help wanted in Roc Toolkit Jan 16, 2025
@singsian
Copy link

Hey! I'd like to work on this issue.

@OdenDillenkoffer
Copy link

Hey, I'd love to take a look at this as well!

@gavv
Copy link
Member Author

gavv commented Feb 5, 2025

Hi, thanks, I guess @singsian could take it, as he/she commented first. @OdenDillenkoffer Feel free to take a look at other help-wanted issues, there is plenty of them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy hacks The solution is expected to be straightforward even if you are new to the project help wanted An important and awaited task but we have no human resources for it yet tests
Projects
Status: Help wanted
Development

No branches or pull requests

3 participants