From 9523062a216a18bfaf91ce365dac73514d666de6 Mon Sep 17 00:00:00 2001 From: Nabila Irfandi Date: Thu, 21 Nov 2024 17:45:11 +0100 Subject: [PATCH 1/7] added untrackedValue --- .../signals_core/lib/src/core/signal.dart | 15 ++++++++++ .../signals_core/lib/src/core/wrappers.dart | 3 ++ .../test/core/untracked_test.dart | 28 +++++++++++++++++++ 3 files changed, 46 insertions(+) diff --git a/packages/signals_core/lib/src/core/signal.dart b/packages/signals_core/lib/src/core/signal.dart index 3a3da799..0dfa7a21 100644 --- a/packages/signals_core/lib/src/core/signal.dart +++ b/packages/signals_core/lib/src/core/signal.dart @@ -548,6 +548,21 @@ class Signal extends ReadonlySignal { return _value; } + /// Run a callback function that returns the signal value without + /// subscribing to the signal updates. + T get untrackedValue { + if (_lazy) { + throw LazySignalInitializationError(this); + } + if (disposed) { + if (kDebugMode) { + print( + 'signal warning: [$globalId|$debugLabel] has been read after disposed: ${StackTrace.current}'); + } + } + return untracked(() => _value); + } + /// Returns a readonly signal ReadonlySignal readonly() => this; diff --git a/packages/signals_core/lib/src/core/wrappers.dart b/packages/signals_core/lib/src/core/wrappers.dart index 5816cef3..3047d371 100644 --- a/packages/signals_core/lib/src/core/wrappers.dart +++ b/packages/signals_core/lib/src/core/wrappers.dart @@ -100,4 +100,7 @@ class WrappedSignal extends WrappedReadonlySignal> @override set value(T val) => source.value = val; + + @override + get untrackedValue => untracked(() => source.value); } diff --git a/packages/signals_core/test/core/untracked_test.dart b/packages/signals_core/test/core/untracked_test.dart index d093d11b..ab7900cd 100644 --- a/packages/signals_core/test/core/untracked_test.dart +++ b/packages/signals_core/test/core/untracked_test.dart @@ -30,4 +30,32 @@ void main() { expect(calls, 1); }); }); + + group('untrackedValue', () { + test('single', () { + final s = signal(0); + int calls = 0; + final dis = effect(() { + s.value; + s.untrackedValue + 1; + calls++; + }); + dis(); + + expect(calls, 1); + }); + + test('nested', () { + final s = signal(0); + int calls = 0; + final dis = effect(() { + s.value; + untracked(() => s.untrackedValue + 1); + calls++; + }); + dis(); + + expect(calls, 1); + }); + }); } From 0bc91794b438ba882f3e9204ab169d1e976d15b6 Mon Sep 17 00:00:00 2001 From: Nabila Irfandi Date: Thu, 21 Nov 2024 18:22:33 +0100 Subject: [PATCH 2/7] dependency_overrides for enforcing the use of all local signals packages --- examples/animations_example/pubspec.yaml | 13 ++++++++++++- examples/auth_flow/pubspec.yaml | 13 ++++++++++++- examples/clean_architecture/pubspec.yaml | 13 ++++++++++++- examples/crud_dio/pubspec.yaml | 13 ++++++++++++- examples/dart_examples/pubspec.yaml | 13 ++++++++++++- examples/dart_mappable_example/pubspec.yaml | 13 ++++++++++++- examples/drift_example/pubspec.yaml | 13 ++++++++++++- examples/eval_calculator/pubspec.yaml | 13 ++++++++++++- examples/flutter_async/pubspec.yaml | 13 ++++++++++++- examples/flutter_colorband/pubspec.yaml | 13 ++++++++++++- examples/flutter_counter/pubspec.yaml | 13 ++++++++++++- examples/get_it_signals/pubspec.yaml | 13 ++++++++++++- examples/html_canvas/pubspec.yaml | 13 ++++++++++++- examples/html_todo_app/pubspec.yaml | 13 ++++++++++++- examples/infinite_scroll/pubspec.yaml | 13 ++++++++++++- examples/node_based_editor/pubspec.yaml | 13 ++++++++++++- examples/persist_shared_preferences/pubspec.yaml | 13 ++++++++++++- examples/rxdart/pubspec.yaml | 13 ++++++++++++- examples/shopping_cart/pubspec.yaml | 13 ++++++++++++- 19 files changed, 228 insertions(+), 19 deletions(-) diff --git a/examples/animations_example/pubspec.yaml b/examples/animations_example/pubspec.yaml index 1fe4903a..734675ca 100644 --- a/examples/animations_example/pubspec.yaml +++ b/examples/animations_example/pubspec.yaml @@ -10,7 +10,6 @@ dependencies: sdk: flutter cupertino_icons: ^1.0.6 - signals: ^5.5.0 dev_dependencies: flutter_test: @@ -18,6 +17,18 @@ dev_dependencies: flutter_lints: ^3.0.0 +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + flutter: uses-material-design: true \ No newline at end of file diff --git a/examples/auth_flow/pubspec.yaml b/examples/auth_flow/pubspec.yaml index d076ce81..840be7d3 100644 --- a/examples/auth_flow/pubspec.yaml +++ b/examples/auth_flow/pubspec.yaml @@ -11,7 +11,6 @@ dependencies: sdk: flutter cupertino_icons: ^1.0.8 - signals: ^5.5.0 go_router: ^13.2.4 dev_dependencies: @@ -20,5 +19,17 @@ dev_dependencies: flutter_lints: ^3.0.2 +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + flutter: uses-material-design: true diff --git a/examples/clean_architecture/pubspec.yaml b/examples/clean_architecture/pubspec.yaml index b2d7090a..dfa5f996 100644 --- a/examples/clean_architecture/pubspec.yaml +++ b/examples/clean_architecture/pubspec.yaml @@ -11,7 +11,6 @@ dependencies: cupertino_icons: ^1.0.8 sqlite_async: ^0.6.1 - signals: ^5.5.0 path_provider: ^2.1.3 dev_dependencies: @@ -19,5 +18,17 @@ dev_dependencies: sdk: flutter flutter_lints: ^3.0.2 +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + flutter: uses-material-design: true diff --git a/examples/crud_dio/pubspec.yaml b/examples/crud_dio/pubspec.yaml index 94113504..770842b4 100644 --- a/examples/crud_dio/pubspec.yaml +++ b/examples/crud_dio/pubspec.yaml @@ -11,7 +11,6 @@ dependencies: sdk: flutter cupertino_icons: ^1.0.8 - signals: ^5.5.0 dio: ^5.4.3+1 retrofit: ^4.1.0 json_annotation: ^4.8.1 @@ -26,6 +25,18 @@ dev_dependencies: copy_with_extension_gen: ^5.0.4 retrofit_generator: '>=8.1.0' +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + flutter: uses-material-design: true diff --git a/examples/dart_examples/pubspec.yaml b/examples/dart_examples/pubspec.yaml index edd8169c..f78b7112 100644 --- a/examples/dart_examples/pubspec.yaml +++ b/examples/dart_examples/pubspec.yaml @@ -8,9 +8,20 @@ environment: dependencies: collection: ^1.18.0 - signals: ^5.5.0 sqlite_async: ^0.6.1 test: ^1.25.2 dev_dependencies: lints: ^3.0.0 + +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint diff --git a/examples/dart_mappable_example/pubspec.yaml b/examples/dart_mappable_example/pubspec.yaml index 842de1b0..5602b200 100644 --- a/examples/dart_mappable_example/pubspec.yaml +++ b/examples/dart_mappable_example/pubspec.yaml @@ -11,7 +11,6 @@ dependencies: dart_mappable: ^4.2.2 flutter: sdk: flutter - signals: ^5.5.0 dev_dependencies: flutter_test: @@ -20,4 +19,16 @@ dev_dependencies: build_runner: ^2.4.11 dart_mappable_builder: ^4.2.3 +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + flutter: diff --git a/examples/drift_example/pubspec.yaml b/examples/drift_example/pubspec.yaml index 18258a8d..2e4bd132 100644 --- a/examples/drift_example/pubspec.yaml +++ b/examples/drift_example/pubspec.yaml @@ -14,7 +14,6 @@ dependencies: path_provider: ^2.1.3 path: ^1.9.0 go_router: ^13.2.4 - signals: ^5.5.0 flutter_colorpicker: ^1.0.3 file_picker: ^8.0.0+1 sqlite3: ^2.4.2 @@ -27,5 +26,17 @@ dev_dependencies: build: ^2.4.1 build_web_compilers: ^4.0.10 +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + flutter: uses-material-design: true diff --git a/examples/eval_calculator/pubspec.yaml b/examples/eval_calculator/pubspec.yaml index d2b59b38..95ab5235 100644 --- a/examples/eval_calculator/pubspec.yaml +++ b/examples/eval_calculator/pubspec.yaml @@ -9,7 +9,6 @@ environment: dependencies: flutter: sdk: flutter - signals: ^5.5.0 analyzer: '>=6.4.1' cupertino_icons: ^1.0.8 material_table_view: ^4.0.2 @@ -19,5 +18,17 @@ dev_dependencies: sdk: flutter flutter_lints: ^3.0.2 +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + flutter: uses-material-design: true diff --git a/examples/flutter_async/pubspec.yaml b/examples/flutter_async/pubspec.yaml index cb9f5b16..d30b2926 100644 --- a/examples/flutter_async/pubspec.yaml +++ b/examples/flutter_async/pubspec.yaml @@ -10,12 +10,23 @@ dependencies: flutter: sdk: flutter cupertino_icons: ^1.0.8 - signals: ^5.5.0 dev_dependencies: flutter_test: sdk: flutter flutter_lints: ^3.0.2 +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + flutter: uses-material-design: true diff --git a/examples/flutter_colorband/pubspec.yaml b/examples/flutter_colorband/pubspec.yaml index 34a755ca..a5721ee5 100644 --- a/examples/flutter_colorband/pubspec.yaml +++ b/examples/flutter_colorband/pubspec.yaml @@ -9,7 +9,6 @@ environment: dependencies: flutter: sdk: flutter - signals: ^5.5.0 rxdart: ^0.27.7 flutter_xlider: ^3.5.0 layout: ^1.0.5 @@ -23,5 +22,17 @@ dev_dependencies: dart_mappable_builder: ^4.2.3 flutter_lints: ^3.0.2 +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + flutter: uses-material-design: true diff --git a/examples/flutter_counter/pubspec.yaml b/examples/flutter_counter/pubspec.yaml index eef035a1..8ddbf543 100644 --- a/examples/flutter_counter/pubspec.yaml +++ b/examples/flutter_counter/pubspec.yaml @@ -9,12 +9,23 @@ dependencies: flutter: sdk: flutter cupertino_icons: ^1.0.8 - signals: ^5.5.0 dev_dependencies: flutter_test: sdk: flutter flutter_lints: ^3.0.2 +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + flutter: uses-material-design: true diff --git a/examples/get_it_signals/pubspec.yaml b/examples/get_it_signals/pubspec.yaml index f1cc9954..2247b7f6 100644 --- a/examples/get_it_signals/pubspec.yaml +++ b/examples/get_it_signals/pubspec.yaml @@ -11,12 +11,23 @@ dependencies: sdk: flutter get_it: ^7.7.0 go_router: ^13.2.4 - signals: ^5.5.0 dev_dependencies: flutter_test: sdk: flutter flutter_lints: ^3.0.2 +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + flutter: uses-material-design: true diff --git a/examples/html_canvas/pubspec.yaml b/examples/html_canvas/pubspec.yaml index cf280ad0..498cea50 100644 --- a/examples/html_canvas/pubspec.yaml +++ b/examples/html_canvas/pubspec.yaml @@ -8,12 +8,23 @@ environment: dependencies: web: ^0.5.1 - signals: ^5.5.0 dev_dependencies: build_runner: ^2.4.9 build_web_compilers: ^4.0.10 lints: ^3.0.0 +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + scripts: dev: webdev serve diff --git a/examples/html_todo_app/pubspec.yaml b/examples/html_todo_app/pubspec.yaml index 73958596..410b017d 100644 --- a/examples/html_todo_app/pubspec.yaml +++ b/examples/html_todo_app/pubspec.yaml @@ -8,12 +8,23 @@ environment: dependencies: web: ^0.5.1 - signals: ^5.5.0 dev_dependencies: build_runner: ^2.4.9 build_web_compilers: ^4.0.10 lints: ^3.0.0 +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + scripts: dev: webdev serve diff --git a/examples/infinite_scroll/pubspec.yaml b/examples/infinite_scroll/pubspec.yaml index efd81f6c..b0d12c55 100644 --- a/examples/infinite_scroll/pubspec.yaml +++ b/examples/infinite_scroll/pubspec.yaml @@ -8,12 +8,23 @@ environment: dependencies: flutter: sdk: flutter - signals: ^5.5.0 dev_dependencies: flutter_test: sdk: flutter flutter_lints: ^3.0.0 +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + flutter: uses-material-design: true diff --git a/examples/node_based_editor/pubspec.yaml b/examples/node_based_editor/pubspec.yaml index 8ab3b484..70c089ab 100644 --- a/examples/node_based_editor/pubspec.yaml +++ b/examples/node_based_editor/pubspec.yaml @@ -9,12 +9,23 @@ environment: dependencies: flutter: sdk: flutter - signals: ^5.5.0 dev_dependencies: flutter_test: sdk: flutter flutter_lints: ^3.0.2 +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + flutter: uses-material-design: true diff --git a/examples/persist_shared_preferences/pubspec.yaml b/examples/persist_shared_preferences/pubspec.yaml index c2d29370..5f722493 100644 --- a/examples/persist_shared_preferences/pubspec.yaml +++ b/examples/persist_shared_preferences/pubspec.yaml @@ -9,7 +9,6 @@ dependencies: flutter: sdk: flutter cupertino_icons: ^1.0.8 - signals: ^5.5.0 shared_preferences: ^2.2.3 dev_dependencies: @@ -17,5 +16,17 @@ dev_dependencies: sdk: flutter flutter_lints: ^3.0.2 +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + flutter: uses-material-design: true diff --git a/examples/rxdart/pubspec.yaml b/examples/rxdart/pubspec.yaml index 4097cd6a..3ef0a81e 100644 --- a/examples/rxdart/pubspec.yaml +++ b/examples/rxdart/pubspec.yaml @@ -9,9 +9,20 @@ environment: dependencies: collection: ^1.18.0 rxdart: ^0.27.7 - signals: ^5.5.0 dev_dependencies: build_runner: ^2.4.9 build_web_compilers: ^4.0.10 lints: ^3.0.0 + +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint diff --git a/examples/shopping_cart/pubspec.yaml b/examples/shopping_cart/pubspec.yaml index b27b3dfa..de473865 100644 --- a/examples/shopping_cart/pubspec.yaml +++ b/examples/shopping_cart/pubspec.yaml @@ -13,7 +13,6 @@ dependencies: flutter_localizations: sdk: flutter lite_ref: ^0.7.0 - signals: ^5.5.0 dev_dependencies: flutter_lints: ^3.0.2 @@ -21,6 +20,18 @@ dev_dependencies: sdk: flutter mocktail: ^1.0.3 +dependency_overrides: + preact_signals: + path: ../../packages/preact_signals + signals: + path: ../../packages/signals + signals_core: + path: ../../packages/signals_core + signals_flutter: + path: ../../packages/signals_flutter + signals_lint: + path: ../../packages/signals_lint + flutter: uses-material-design: true From 36c552b8d973303d896da70723c0aa521a24bf5d Mon Sep 17 00:00:00 2001 From: Nabila Irfandi Date: Thu, 21 Nov 2024 19:27:30 +0100 Subject: [PATCH 3/7] Revert "added untrackedValue" This reverts commit 9523062a216a18bfaf91ce365dac73514d666de6. --- .../signals_core/lib/src/core/signal.dart | 15 ---------- .../signals_core/lib/src/core/wrappers.dart | 3 -- .../test/core/untracked_test.dart | 28 ------------------- 3 files changed, 46 deletions(-) diff --git a/packages/signals_core/lib/src/core/signal.dart b/packages/signals_core/lib/src/core/signal.dart index 0dfa7a21..3a3da799 100644 --- a/packages/signals_core/lib/src/core/signal.dart +++ b/packages/signals_core/lib/src/core/signal.dart @@ -548,21 +548,6 @@ class Signal extends ReadonlySignal { return _value; } - /// Run a callback function that returns the signal value without - /// subscribing to the signal updates. - T get untrackedValue { - if (_lazy) { - throw LazySignalInitializationError(this); - } - if (disposed) { - if (kDebugMode) { - print( - 'signal warning: [$globalId|$debugLabel] has been read after disposed: ${StackTrace.current}'); - } - } - return untracked(() => _value); - } - /// Returns a readonly signal ReadonlySignal readonly() => this; diff --git a/packages/signals_core/lib/src/core/wrappers.dart b/packages/signals_core/lib/src/core/wrappers.dart index 3047d371..5816cef3 100644 --- a/packages/signals_core/lib/src/core/wrappers.dart +++ b/packages/signals_core/lib/src/core/wrappers.dart @@ -100,7 +100,4 @@ class WrappedSignal extends WrappedReadonlySignal> @override set value(T val) => source.value = val; - - @override - get untrackedValue => untracked(() => source.value); } diff --git a/packages/signals_core/test/core/untracked_test.dart b/packages/signals_core/test/core/untracked_test.dart index ab7900cd..d093d11b 100644 --- a/packages/signals_core/test/core/untracked_test.dart +++ b/packages/signals_core/test/core/untracked_test.dart @@ -30,32 +30,4 @@ void main() { expect(calls, 1); }); }); - - group('untrackedValue', () { - test('single', () { - final s = signal(0); - int calls = 0; - final dis = effect(() { - s.value; - s.untrackedValue + 1; - calls++; - }); - dis(); - - expect(calls, 1); - }); - - test('nested', () { - final s = signal(0); - int calls = 0; - final dis = effect(() { - s.value; - untracked(() => s.untrackedValue + 1); - calls++; - }); - dis(); - - expect(calls, 1); - }); - }); } From f94017ff0a526f18e358278ad1724ee96d7d4840 Mon Sep 17 00:00:00 2001 From: Nabila Irfandi Date: Thu, 21 Nov 2024 19:41:32 +0100 Subject: [PATCH 4/7] added .untrackedValue as an extension --- .../lib/src/extensions/signal.dart | 9 +++++ .../test/extension/untracked_value_test.dart | 33 +++++++++++++++++++ 2 files changed, 42 insertions(+) create mode 100644 packages/signals_flutter/test/extension/untracked_value_test.dart diff --git a/packages/signals_flutter/lib/src/extensions/signal.dart b/packages/signals_flutter/lib/src/extensions/signal.dart index 2ae03e0c..0cc923cc 100644 --- a/packages/signals_flutter/lib/src/extensions/signal.dart +++ b/packages/signals_flutter/lib/src/extensions/signal.dart @@ -70,6 +70,15 @@ extension FlutterReadonlySignalUtils on ReadonlySignal { return SignalValueListenable, ReadonlySignal>.fromSignal(this); } + + /// Runs a callback function that returns the signal value without + /// subscribing to the signal updates. + /// + /// ```dart + /// final counter = signal(0); + /// final untrackedValue = counter.untrackedValue; + /// ``` + T get untrackedValue => untracked(() => value); } /// Mutable signal utils diff --git a/packages/signals_flutter/test/extension/untracked_value_test.dart b/packages/signals_flutter/test/extension/untracked_value_test.dart new file mode 100644 index 00000000..67d62faf --- /dev/null +++ b/packages/signals_flutter/test/extension/untracked_value_test.dart @@ -0,0 +1,33 @@ +import 'package:flutter_test/flutter_test.dart'; +import 'package:signals_flutter/signals_flutter.dart'; + +void main() { + SignalsObserver.instance = null; + group('untrackedValue', () { + test('single', () { + final s = signal(0); + int calls = 0; + final dis = effect(() { + s.value; + s.untrackedValue + 1; + calls++; + }); + dis(); + + expect(calls, 1); + }); + + test('nested', () { + final s = signal(0); + int calls = 0; + final dis = effect(() { + s.value; + untracked(() => s.untrackedValue + 1); + calls++; + }); + dis(); + + expect(calls, 1); + }); + }); +} From 4f934d2b3ee320f703691fd935f0a8d84cc3ef43 Mon Sep 17 00:00:00 2001 From: Nabila Irfandi Date: Thu, 21 Nov 2024 20:35:19 +0100 Subject: [PATCH 5/7] Revert "dependency_overrides for enforcing the use of all local signals packages" This reverts commit 0bc91794b438ba882f3e9204ab169d1e976d15b6. --- examples/animations_example/pubspec.yaml | 13 +------------ examples/auth_flow/pubspec.yaml | 13 +------------ examples/clean_architecture/pubspec.yaml | 13 +------------ examples/crud_dio/pubspec.yaml | 13 +------------ examples/dart_examples/pubspec.yaml | 13 +------------ examples/dart_mappable_example/pubspec.yaml | 13 +------------ examples/drift_example/pubspec.yaml | 13 +------------ examples/eval_calculator/pubspec.yaml | 13 +------------ examples/flutter_async/pubspec.yaml | 13 +------------ examples/flutter_colorband/pubspec.yaml | 13 +------------ examples/flutter_counter/pubspec.yaml | 13 +------------ examples/get_it_signals/pubspec.yaml | 13 +------------ examples/html_canvas/pubspec.yaml | 13 +------------ examples/html_todo_app/pubspec.yaml | 13 +------------ examples/infinite_scroll/pubspec.yaml | 13 +------------ examples/node_based_editor/pubspec.yaml | 13 +------------ examples/persist_shared_preferences/pubspec.yaml | 13 +------------ examples/rxdart/pubspec.yaml | 13 +------------ examples/shopping_cart/pubspec.yaml | 13 +------------ 19 files changed, 19 insertions(+), 228 deletions(-) diff --git a/examples/animations_example/pubspec.yaml b/examples/animations_example/pubspec.yaml index 734675ca..1fe4903a 100644 --- a/examples/animations_example/pubspec.yaml +++ b/examples/animations_example/pubspec.yaml @@ -10,6 +10,7 @@ dependencies: sdk: flutter cupertino_icons: ^1.0.6 + signals: ^5.5.0 dev_dependencies: flutter_test: @@ -17,18 +18,6 @@ dev_dependencies: flutter_lints: ^3.0.0 -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - flutter: uses-material-design: true \ No newline at end of file diff --git a/examples/auth_flow/pubspec.yaml b/examples/auth_flow/pubspec.yaml index 840be7d3..d076ce81 100644 --- a/examples/auth_flow/pubspec.yaml +++ b/examples/auth_flow/pubspec.yaml @@ -11,6 +11,7 @@ dependencies: sdk: flutter cupertino_icons: ^1.0.8 + signals: ^5.5.0 go_router: ^13.2.4 dev_dependencies: @@ -19,17 +20,5 @@ dev_dependencies: flutter_lints: ^3.0.2 -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - flutter: uses-material-design: true diff --git a/examples/clean_architecture/pubspec.yaml b/examples/clean_architecture/pubspec.yaml index dfa5f996..b2d7090a 100644 --- a/examples/clean_architecture/pubspec.yaml +++ b/examples/clean_architecture/pubspec.yaml @@ -11,6 +11,7 @@ dependencies: cupertino_icons: ^1.0.8 sqlite_async: ^0.6.1 + signals: ^5.5.0 path_provider: ^2.1.3 dev_dependencies: @@ -18,17 +19,5 @@ dev_dependencies: sdk: flutter flutter_lints: ^3.0.2 -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - flutter: uses-material-design: true diff --git a/examples/crud_dio/pubspec.yaml b/examples/crud_dio/pubspec.yaml index 770842b4..94113504 100644 --- a/examples/crud_dio/pubspec.yaml +++ b/examples/crud_dio/pubspec.yaml @@ -11,6 +11,7 @@ dependencies: sdk: flutter cupertino_icons: ^1.0.8 + signals: ^5.5.0 dio: ^5.4.3+1 retrofit: ^4.1.0 json_annotation: ^4.8.1 @@ -25,18 +26,6 @@ dev_dependencies: copy_with_extension_gen: ^5.0.4 retrofit_generator: '>=8.1.0' -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - flutter: uses-material-design: true diff --git a/examples/dart_examples/pubspec.yaml b/examples/dart_examples/pubspec.yaml index f78b7112..edd8169c 100644 --- a/examples/dart_examples/pubspec.yaml +++ b/examples/dart_examples/pubspec.yaml @@ -8,20 +8,9 @@ environment: dependencies: collection: ^1.18.0 + signals: ^5.5.0 sqlite_async: ^0.6.1 test: ^1.25.2 dev_dependencies: lints: ^3.0.0 - -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint diff --git a/examples/dart_mappable_example/pubspec.yaml b/examples/dart_mappable_example/pubspec.yaml index 5602b200..842de1b0 100644 --- a/examples/dart_mappable_example/pubspec.yaml +++ b/examples/dart_mappable_example/pubspec.yaml @@ -11,6 +11,7 @@ dependencies: dart_mappable: ^4.2.2 flutter: sdk: flutter + signals: ^5.5.0 dev_dependencies: flutter_test: @@ -19,16 +20,4 @@ dev_dependencies: build_runner: ^2.4.11 dart_mappable_builder: ^4.2.3 -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - flutter: diff --git a/examples/drift_example/pubspec.yaml b/examples/drift_example/pubspec.yaml index 2e4bd132..18258a8d 100644 --- a/examples/drift_example/pubspec.yaml +++ b/examples/drift_example/pubspec.yaml @@ -14,6 +14,7 @@ dependencies: path_provider: ^2.1.3 path: ^1.9.0 go_router: ^13.2.4 + signals: ^5.5.0 flutter_colorpicker: ^1.0.3 file_picker: ^8.0.0+1 sqlite3: ^2.4.2 @@ -26,17 +27,5 @@ dev_dependencies: build: ^2.4.1 build_web_compilers: ^4.0.10 -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - flutter: uses-material-design: true diff --git a/examples/eval_calculator/pubspec.yaml b/examples/eval_calculator/pubspec.yaml index 95ab5235..d2b59b38 100644 --- a/examples/eval_calculator/pubspec.yaml +++ b/examples/eval_calculator/pubspec.yaml @@ -9,6 +9,7 @@ environment: dependencies: flutter: sdk: flutter + signals: ^5.5.0 analyzer: '>=6.4.1' cupertino_icons: ^1.0.8 material_table_view: ^4.0.2 @@ -18,17 +19,5 @@ dev_dependencies: sdk: flutter flutter_lints: ^3.0.2 -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - flutter: uses-material-design: true diff --git a/examples/flutter_async/pubspec.yaml b/examples/flutter_async/pubspec.yaml index d30b2926..cb9f5b16 100644 --- a/examples/flutter_async/pubspec.yaml +++ b/examples/flutter_async/pubspec.yaml @@ -10,23 +10,12 @@ dependencies: flutter: sdk: flutter cupertino_icons: ^1.0.8 + signals: ^5.5.0 dev_dependencies: flutter_test: sdk: flutter flutter_lints: ^3.0.2 -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - flutter: uses-material-design: true diff --git a/examples/flutter_colorband/pubspec.yaml b/examples/flutter_colorband/pubspec.yaml index a5721ee5..34a755ca 100644 --- a/examples/flutter_colorband/pubspec.yaml +++ b/examples/flutter_colorband/pubspec.yaml @@ -9,6 +9,7 @@ environment: dependencies: flutter: sdk: flutter + signals: ^5.5.0 rxdart: ^0.27.7 flutter_xlider: ^3.5.0 layout: ^1.0.5 @@ -22,17 +23,5 @@ dev_dependencies: dart_mappable_builder: ^4.2.3 flutter_lints: ^3.0.2 -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - flutter: uses-material-design: true diff --git a/examples/flutter_counter/pubspec.yaml b/examples/flutter_counter/pubspec.yaml index 8ddbf543..eef035a1 100644 --- a/examples/flutter_counter/pubspec.yaml +++ b/examples/flutter_counter/pubspec.yaml @@ -9,23 +9,12 @@ dependencies: flutter: sdk: flutter cupertino_icons: ^1.0.8 + signals: ^5.5.0 dev_dependencies: flutter_test: sdk: flutter flutter_lints: ^3.0.2 -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - flutter: uses-material-design: true diff --git a/examples/get_it_signals/pubspec.yaml b/examples/get_it_signals/pubspec.yaml index 2247b7f6..f1cc9954 100644 --- a/examples/get_it_signals/pubspec.yaml +++ b/examples/get_it_signals/pubspec.yaml @@ -11,23 +11,12 @@ dependencies: sdk: flutter get_it: ^7.7.0 go_router: ^13.2.4 + signals: ^5.5.0 dev_dependencies: flutter_test: sdk: flutter flutter_lints: ^3.0.2 -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - flutter: uses-material-design: true diff --git a/examples/html_canvas/pubspec.yaml b/examples/html_canvas/pubspec.yaml index 498cea50..cf280ad0 100644 --- a/examples/html_canvas/pubspec.yaml +++ b/examples/html_canvas/pubspec.yaml @@ -8,23 +8,12 @@ environment: dependencies: web: ^0.5.1 + signals: ^5.5.0 dev_dependencies: build_runner: ^2.4.9 build_web_compilers: ^4.0.10 lints: ^3.0.0 -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - scripts: dev: webdev serve diff --git a/examples/html_todo_app/pubspec.yaml b/examples/html_todo_app/pubspec.yaml index 410b017d..73958596 100644 --- a/examples/html_todo_app/pubspec.yaml +++ b/examples/html_todo_app/pubspec.yaml @@ -8,23 +8,12 @@ environment: dependencies: web: ^0.5.1 + signals: ^5.5.0 dev_dependencies: build_runner: ^2.4.9 build_web_compilers: ^4.0.10 lints: ^3.0.0 -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - scripts: dev: webdev serve diff --git a/examples/infinite_scroll/pubspec.yaml b/examples/infinite_scroll/pubspec.yaml index b0d12c55..efd81f6c 100644 --- a/examples/infinite_scroll/pubspec.yaml +++ b/examples/infinite_scroll/pubspec.yaml @@ -8,23 +8,12 @@ environment: dependencies: flutter: sdk: flutter + signals: ^5.5.0 dev_dependencies: flutter_test: sdk: flutter flutter_lints: ^3.0.0 -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - flutter: uses-material-design: true diff --git a/examples/node_based_editor/pubspec.yaml b/examples/node_based_editor/pubspec.yaml index 70c089ab..8ab3b484 100644 --- a/examples/node_based_editor/pubspec.yaml +++ b/examples/node_based_editor/pubspec.yaml @@ -9,23 +9,12 @@ environment: dependencies: flutter: sdk: flutter + signals: ^5.5.0 dev_dependencies: flutter_test: sdk: flutter flutter_lints: ^3.0.2 -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - flutter: uses-material-design: true diff --git a/examples/persist_shared_preferences/pubspec.yaml b/examples/persist_shared_preferences/pubspec.yaml index 5f722493..c2d29370 100644 --- a/examples/persist_shared_preferences/pubspec.yaml +++ b/examples/persist_shared_preferences/pubspec.yaml @@ -9,6 +9,7 @@ dependencies: flutter: sdk: flutter cupertino_icons: ^1.0.8 + signals: ^5.5.0 shared_preferences: ^2.2.3 dev_dependencies: @@ -16,17 +17,5 @@ dev_dependencies: sdk: flutter flutter_lints: ^3.0.2 -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - flutter: uses-material-design: true diff --git a/examples/rxdart/pubspec.yaml b/examples/rxdart/pubspec.yaml index 3ef0a81e..4097cd6a 100644 --- a/examples/rxdart/pubspec.yaml +++ b/examples/rxdart/pubspec.yaml @@ -9,20 +9,9 @@ environment: dependencies: collection: ^1.18.0 rxdart: ^0.27.7 + signals: ^5.5.0 dev_dependencies: build_runner: ^2.4.9 build_web_compilers: ^4.0.10 lints: ^3.0.0 - -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint diff --git a/examples/shopping_cart/pubspec.yaml b/examples/shopping_cart/pubspec.yaml index de473865..b27b3dfa 100644 --- a/examples/shopping_cart/pubspec.yaml +++ b/examples/shopping_cart/pubspec.yaml @@ -13,6 +13,7 @@ dependencies: flutter_localizations: sdk: flutter lite_ref: ^0.7.0 + signals: ^5.5.0 dev_dependencies: flutter_lints: ^3.0.2 @@ -20,18 +21,6 @@ dev_dependencies: sdk: flutter mocktail: ^1.0.3 -dependency_overrides: - preact_signals: - path: ../../packages/preact_signals - signals: - path: ../../packages/signals - signals_core: - path: ../../packages/signals_core - signals_flutter: - path: ../../packages/signals_flutter - signals_lint: - path: ../../packages/signals_lint - flutter: uses-material-design: true From 6cdd61e3d2de2cd730582a91637d5ed175ef981c Mon Sep 17 00:00:00 2001 From: Nabila Irfandi Date: Thu, 21 Nov 2024 21:03:19 +0100 Subject: [PATCH 6/7] latest melos boostrap on Flutter beta ( fc011960a2 ) --- examples/animations_example/pubspec.lock | 12 +++++------ examples/auth_flow/pubspec.lock | 10 ++++----- examples/clean_architecture/pubspec.lock | 10 ++++----- examples/crud_dio/pubspec.lock | 10 ++++----- examples/dart_examples/pubspec.lock | 2 +- examples/drift_example/pubspec.lock | 2 +- examples/eval_calculator/pubspec.lock | 10 ++++----- examples/flutter_async/pubspec.lock | 10 ++++----- examples/flutter_colorband/pubspec.lock | 10 ++++----- examples/flutter_counter/pubspec.lock | 10 ++++----- examples/get_it_signals/pubspec.lock | 10 ++++----- examples/html_canvas/pubspec.lock | 2 +- examples/html_todo_app/pubspec.lock | 2 +- examples/infinite_scroll/pubspec.lock | 10 ++++----- examples/node_based_editor/pubspec.lock | 10 ++++----- .../persist_shared_preferences/pubspec.lock | 10 ++++----- examples/rxdart/pubspec.lock | 2 +- examples/shopping_cart/pubspec.lock | 10 ++++----- packages/signals/example/pubspec.lock | 8 +++---- .../signals_devtools_extension/pubspec.lock | 10 ++++----- packages/signals_flutter/example/pubspec.lock | 21 +++++++------------ 21 files changed, 87 insertions(+), 94 deletions(-) diff --git a/examples/animations_example/pubspec.lock b/examples/animations_example/pubspec.lock index 84239848..3e32f5a0 100644 --- a/examples/animations_example/pubspec.lock +++ b/examples/animations_example/pubspec.lock @@ -145,7 +145,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" signals: dependency: "direct main" description: @@ -184,10 +184,10 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.0" stream_channel: dependency: transitive description: @@ -232,10 +232,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.3.0" sdks: - dart: ">=3.4.3 <4.0.0" + dart: ">=3.4.0 <4.0.0" flutter: ">=3.18.0-18.0.pre.54" diff --git a/examples/auth_flow/pubspec.lock b/examples/auth_flow/pubspec.lock index b61e0058..adae295b 100644 --- a/examples/auth_flow/pubspec.lock +++ b/examples/auth_flow/pubspec.lock @@ -166,7 +166,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" signals: dependency: "direct main" description: @@ -205,10 +205,10 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.0" stream_channel: dependency: transitive description: @@ -253,10 +253,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.3.0" sdks: dart: ">=3.4.0 <4.0.0" flutter: ">=3.18.0-18.0.pre.54" diff --git a/examples/clean_architecture/pubspec.lock b/examples/clean_architecture/pubspec.lock index 2610b0e9..a507c086 100644 --- a/examples/clean_architecture/pubspec.lock +++ b/examples/clean_architecture/pubspec.lock @@ -217,7 +217,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" signals: dependency: "direct main" description: @@ -272,10 +272,10 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.0" stream_channel: dependency: transitive description: @@ -320,10 +320,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.3.0" web: dependency: transitive description: diff --git a/examples/crud_dio/pubspec.lock b/examples/crud_dio/pubspec.lock index cf0ffb92..9d3c0a24 100644 --- a/examples/crud_dio/pubspec.lock +++ b/examples/crud_dio/pubspec.lock @@ -425,7 +425,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" protobuf: dependency: transitive description: @@ -536,10 +536,10 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.0" stream_channel: dependency: transitive description: @@ -616,10 +616,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.3.0" watcher: dependency: transitive description: diff --git a/examples/dart_examples/pubspec.lock b/examples/dart_examples/pubspec.lock index aad889b6..ac1cd752 100644 --- a/examples/dart_examples/pubspec.lock +++ b/examples/dart_examples/pubspec.lock @@ -236,7 +236,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" pub_semver: dependency: transitive description: diff --git a/examples/drift_example/pubspec.lock b/examples/drift_example/pubspec.lock index f932e447..264422f9 100644 --- a/examples/drift_example/pubspec.lock +++ b/examples/drift_example/pubspec.lock @@ -537,7 +537,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" protobuf: dependency: transitive description: diff --git a/examples/eval_calculator/pubspec.lock b/examples/eval_calculator/pubspec.lock index c2da6314..65371451 100644 --- a/examples/eval_calculator/pubspec.lock +++ b/examples/eval_calculator/pubspec.lock @@ -209,7 +209,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" pub_semver: dependency: transitive description: @@ -256,10 +256,10 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.0" stream_channel: dependency: transitive description: @@ -312,10 +312,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.3.0" watcher: dependency: transitive description: diff --git a/examples/flutter_async/pubspec.lock b/examples/flutter_async/pubspec.lock index 31f2dde1..3e32f5a0 100644 --- a/examples/flutter_async/pubspec.lock +++ b/examples/flutter_async/pubspec.lock @@ -145,7 +145,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" signals: dependency: "direct main" description: @@ -184,10 +184,10 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.0" stream_channel: dependency: transitive description: @@ -232,10 +232,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.3.0" sdks: dart: ">=3.4.0 <4.0.0" flutter: ">=3.18.0-18.0.pre.54" diff --git a/examples/flutter_colorband/pubspec.lock b/examples/flutter_colorband/pubspec.lock index c44fd767..49dc501d 100644 --- a/examples/flutter_colorband/pubspec.lock +++ b/examples/flutter_colorband/pubspec.lock @@ -433,7 +433,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" pub_semver: dependency: transitive description: @@ -520,10 +520,10 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.0" stream_channel: dependency: transitive description: @@ -600,10 +600,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.3.0" watcher: dependency: transitive description: diff --git a/examples/flutter_counter/pubspec.lock b/examples/flutter_counter/pubspec.lock index 31f2dde1..3e32f5a0 100644 --- a/examples/flutter_counter/pubspec.lock +++ b/examples/flutter_counter/pubspec.lock @@ -145,7 +145,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" signals: dependency: "direct main" description: @@ -184,10 +184,10 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.0" stream_channel: dependency: transitive description: @@ -232,10 +232,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.3.0" sdks: dart: ">=3.4.0 <4.0.0" flutter: ">=3.18.0-18.0.pre.54" diff --git a/examples/get_it_signals/pubspec.lock b/examples/get_it_signals/pubspec.lock index 72425bc8..123d1a8a 100644 --- a/examples/get_it_signals/pubspec.lock +++ b/examples/get_it_signals/pubspec.lock @@ -166,7 +166,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" signals: dependency: "direct main" description: @@ -205,10 +205,10 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.0" stream_channel: dependency: transitive description: @@ -253,10 +253,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.3.0" sdks: dart: ">=3.4.0 <4.0.0" flutter: ">=3.18.0-18.0.pre.54" diff --git a/examples/html_canvas/pubspec.lock b/examples/html_canvas/pubspec.lock index 57803471..95dddd5c 100644 --- a/examples/html_canvas/pubspec.lock +++ b/examples/html_canvas/pubspec.lock @@ -356,7 +356,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" protobuf: dependency: transitive description: diff --git a/examples/html_todo_app/pubspec.lock b/examples/html_todo_app/pubspec.lock index 57803471..95dddd5c 100644 --- a/examples/html_todo_app/pubspec.lock +++ b/examples/html_todo_app/pubspec.lock @@ -356,7 +356,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" protobuf: dependency: transitive description: diff --git a/examples/infinite_scroll/pubspec.lock b/examples/infinite_scroll/pubspec.lock index 55914fcf..5cb2f541 100644 --- a/examples/infinite_scroll/pubspec.lock +++ b/examples/infinite_scroll/pubspec.lock @@ -137,7 +137,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" signals: dependency: "direct main" description: @@ -176,10 +176,10 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.0" stream_channel: dependency: transitive description: @@ -224,10 +224,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.3.0" sdks: dart: ">=3.4.0 <4.0.0" flutter: ">=3.18.0-18.0.pre.54" diff --git a/examples/node_based_editor/pubspec.lock b/examples/node_based_editor/pubspec.lock index 55914fcf..5cb2f541 100644 --- a/examples/node_based_editor/pubspec.lock +++ b/examples/node_based_editor/pubspec.lock @@ -137,7 +137,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" signals: dependency: "direct main" description: @@ -176,10 +176,10 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.0" stream_channel: dependency: transitive description: @@ -224,10 +224,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.3.0" sdks: dart: ">=3.4.0 <4.0.0" flutter: ">=3.18.0-18.0.pre.54" diff --git a/examples/persist_shared_preferences/pubspec.lock b/examples/persist_shared_preferences/pubspec.lock index ddd06fff..d65f3cef 100644 --- a/examples/persist_shared_preferences/pubspec.lock +++ b/examples/persist_shared_preferences/pubspec.lock @@ -206,7 +206,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" shared_preferences: dependency: "direct main" description: @@ -301,10 +301,10 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.0" stream_channel: dependency: transitive description: @@ -349,10 +349,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.3.0" web: dependency: transitive description: diff --git a/examples/rxdart/pubspec.lock b/examples/rxdart/pubspec.lock index b342883d..8c72d7f1 100644 --- a/examples/rxdart/pubspec.lock +++ b/examples/rxdart/pubspec.lock @@ -356,7 +356,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" protobuf: dependency: transitive description: diff --git a/examples/shopping_cart/pubspec.lock b/examples/shopping_cart/pubspec.lock index 88678f70..aa7c5d9b 100644 --- a/examples/shopping_cart/pubspec.lock +++ b/examples/shopping_cart/pubspec.lock @@ -190,7 +190,7 @@ packages: path: "../../packages/preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" signals: dependency: "direct main" description: @@ -229,10 +229,10 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.0" stream_channel: dependency: transitive description: @@ -277,10 +277,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.3.0" sdks: dart: ">=3.4.0 <4.0.0" flutter: ">=3.18.0-18.0.pre.54" diff --git a/packages/signals/example/pubspec.lock b/packages/signals/example/pubspec.lock index 70eeba03..a993b17d 100644 --- a/packages/signals/example/pubspec.lock +++ b/packages/signals/example/pubspec.lock @@ -179,10 +179,10 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.0" stream_channel: dependency: transitive description: @@ -227,10 +227,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.3.0" sdks: dart: ">=3.4.0 <4.0.0" flutter: ">=3.18.0-18.0.pre.54" diff --git a/packages/signals_devtools_extension/pubspec.lock b/packages/signals_devtools_extension/pubspec.lock index d89ba417..4d9e1495 100644 --- a/packages/signals_devtools_extension/pubspec.lock +++ b/packages/signals_devtools_extension/pubspec.lock @@ -318,7 +318,7 @@ packages: path: "../preact_signals" relative: true source: path - version: "1.8.1" + version: "1.8.3" shelf: dependency: transitive description: @@ -373,10 +373,10 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.0" stream_channel: dependency: transitive description: @@ -501,10 +501,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.3.0" web: dependency: transitive description: diff --git a/packages/signals_flutter/example/pubspec.lock b/packages/signals_flutter/example/pubspec.lock index 5f424dc2..bb147c04 100644 --- a/packages/signals_flutter/example/pubspec.lock +++ b/packages/signals_flutter/example/pubspec.lock @@ -131,20 +131,13 @@ packages: url: "https://pub.dev" source: hosted version: "1.9.0" - preact_signals: + signals_core: dependency: transitive description: - name: preact_signals - sha256: "04e152edefaecd8a5ba96393644cc96f61cddd3b261877aba79f96410c35622f" + name: signals_core + sha256: f4af1dd285e89bf0bb268676c9d175ea6fb6a894d81260f6b564decad46ad240 url: "https://pub.dev" source: hosted - version: "1.8.1" - signals_core: - dependency: "direct overridden" - description: - path: "../../signals_core" - relative: true - source: path version: "5.5.0" signals_flutter: dependency: "direct main" @@ -170,10 +163,10 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.0" stream_channel: dependency: transitive description: @@ -218,10 +211,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.3.0" sdks: dart: ">=3.4.0 <4.0.0" flutter: ">=3.18.0-18.0.pre.54" From c7045bff434c077d6eca2a687e6ba3c0c19a9f12 Mon Sep 17 00:00:00 2001 From: Nabila Irfandi Date: Thu, 21 Nov 2024 21:38:31 +0100 Subject: [PATCH 7/7] isolate the .untrackedValue extension --- packages/signals_flutter/lib/extended.dart | 3 ++- .../signals_flutter/lib/src/extensions/signal.dart | 9 --------- .../lib/src/extensions/untracked_value.dart | 13 +++++++++++++ .../test/extension/untracked_value_test.dart | 1 + 4 files changed, 16 insertions(+), 10 deletions(-) create mode 100644 packages/signals_flutter/lib/src/extensions/untracked_value.dart diff --git a/packages/signals_flutter/lib/extended.dart b/packages/signals_flutter/lib/extended.dart index 265890f9..03df2828 100644 --- a/packages/signals_flutter/lib/extended.dart +++ b/packages/signals_flutter/lib/extended.dart @@ -8,4 +8,5 @@ export 'src/flutter/scheduler_binding.dart'; export 'src/flutter/inherited_widget/signal.dart'; export 'src/flutter/inherited_widget/computed.dart'; export 'src/flutter/inherited_widget/readonly.dart'; -export 'src/flutter/inherited_widget/provider.dart'; \ No newline at end of file +export 'src/flutter/inherited_widget/provider.dart'; +export 'src/extensions/untracked_value.dart'; diff --git a/packages/signals_flutter/lib/src/extensions/signal.dart b/packages/signals_flutter/lib/src/extensions/signal.dart index 0cc923cc..2ae03e0c 100644 --- a/packages/signals_flutter/lib/src/extensions/signal.dart +++ b/packages/signals_flutter/lib/src/extensions/signal.dart @@ -70,15 +70,6 @@ extension FlutterReadonlySignalUtils on ReadonlySignal { return SignalValueListenable, ReadonlySignal>.fromSignal(this); } - - /// Runs a callback function that returns the signal value without - /// subscribing to the signal updates. - /// - /// ```dart - /// final counter = signal(0); - /// final untrackedValue = counter.untrackedValue; - /// ``` - T get untrackedValue => untracked(() => value); } /// Mutable signal utils diff --git a/packages/signals_flutter/lib/src/extensions/untracked_value.dart b/packages/signals_flutter/lib/src/extensions/untracked_value.dart new file mode 100644 index 00000000..84eecd97 --- /dev/null +++ b/packages/signals_flutter/lib/src/extensions/untracked_value.dart @@ -0,0 +1,13 @@ +import 'package:signals_core/signals_core.dart'; + +/// Signal extensions +extension ReadonlySignalUntrackedValueUtils on ReadonlySignal { + /// Runs a callback function that returns the signal value without + /// subscribing to the signal updates. + /// + /// ```dart + /// final counter = signal(0); + /// final untrackedValue = counter.untrackedValue; + /// ``` + T get untrackedValue => untracked(() => value); +} diff --git a/packages/signals_flutter/test/extension/untracked_value_test.dart b/packages/signals_flutter/test/extension/untracked_value_test.dart index 67d62faf..42ad8184 100644 --- a/packages/signals_flutter/test/extension/untracked_value_test.dart +++ b/packages/signals_flutter/test/extension/untracked_value_test.dart @@ -1,4 +1,5 @@ import 'package:flutter_test/flutter_test.dart'; +import 'package:signals_flutter/extended.dart'; import 'package:signals_flutter/signals_flutter.dart'; void main() {