Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen ratio is being set in reverse #6

Open
hunhee98 opened this issue Nov 23, 2023 · 0 comments
Open

Screen ratio is being set in reverse #6

hunhee98 opened this issue Nov 23, 2023 · 0 comments

Comments

@hunhee98
Copy link

Hello, I'm an iOS developer working in Korea. I implemented real-time screen sharing functionality using your library. Thank you. However, I've encountered a problem. When testing on an iPad, it seems that the screen ratio is saved in reverse when creating the writer instance by passing screen.bounds.size directly.

So, when I initialize it in reverse, it worked well, like the code below:

let width = screen.bounds.size.width
let height = screen.bounds.size.height

writer = try .init(
  outputURL: nodeURL,
  screenSize: .init(width: height, height: width),
  screenScale: 3
)

When I changed it to pass the values in accordance with the iPad ratio, the video was saved correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant