From ab16591dad3e5f2854c4be5a457408b601400393 Mon Sep 17 00:00:00 2001 From: Roman Radchenko Date: Mon, 29 Dec 2025 20:29:40 +0200 Subject: [PATCH 1/7] ci: run check on pull requests --- .github/workflows/check.yml | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 .github/workflows/check.yml diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml new file mode 100644 index 0000000..c9b1f7c --- /dev/null +++ b/.github/workflows/check.yml @@ -0,0 +1,31 @@ +name: check + +on: + pull_request: + push: + branches: + - main + +concurrency: + group: check-${{ github.ref }} + cancel-in-progress: true + +jobs: + check: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + + - uses: actions/setup-node@v4 + with: + node-version: 20 + cache: npm + + - name: Install dependencies + run: npm ci + + - name: Install Playwright browsers + run: npx playwright install --with-deps + + - name: Run checks + run: npm run check From 54c68aa458e1dfc62c2682ebbd228669c9570aee Mon Sep 17 00:00:00 2001 From: Roman Radchenko Date: Mon, 29 Dec 2025 20:32:43 +0200 Subject: [PATCH 2/7] ci: split lint, typecheck, test --- .github/workflows/check.yml | 40 +++++++++++++++++++++++++++++++++---- 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index c9b1f7c..0558044 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -1,4 +1,4 @@ -name: check +name: ci on: pull_request: @@ -11,7 +11,39 @@ concurrency: cancel-in-progress: true jobs: - check: + lint: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + + - uses: actions/setup-node@v4 + with: + node-version: 20 + cache: npm + + - name: Install dependencies + run: npm ci + + - name: Lint + run: npm run lint + + typecheck: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + + - uses: actions/setup-node@v4 + with: + node-version: 20 + cache: npm + + - name: Install dependencies + run: npm ci + + - name: Typecheck + run: npm run typecheck + + test: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 @@ -27,5 +59,5 @@ jobs: - name: Install Playwright browsers run: npx playwright install --with-deps - - name: Run checks - run: npm run check + - name: Test + run: npm run test From edf324c857a3cbcb605cfc5fac324cbc9f584476 Mon Sep 17 00:00:00 2001 From: Roman Radchenko Date: Mon, 29 Dec 2025 20:48:22 +0200 Subject: [PATCH 3/7] ci: build before tests --- .github/workflows/check.yml | 3 +++ examples/next-admin-auth/playwright.config.ts | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 0558044..c8331a2 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -56,6 +56,9 @@ jobs: - name: Install dependencies run: npm ci + - name: Build workspace + run: npm run build + - name: Install Playwright browsers run: npx playwright install --with-deps diff --git a/examples/next-admin-auth/playwright.config.ts b/examples/next-admin-auth/playwright.config.ts index fa6fa4a..84381b4 100644 --- a/examples/next-admin-auth/playwright.config.ts +++ b/examples/next-admin-auth/playwright.config.ts @@ -11,7 +11,7 @@ export default defineConfig({ use: { baseURL: "http://127.0.0.1:3017", actionTimeout: 10_000, - navigationTimeout: 30_000, + navigationTimeout: 60_000, }, webServer: { command: "npm run dev", From 5f199a7c54fb1d5fc15c6680c020a401c1f994c8 Mon Sep 17 00:00:00 2001 From: Roman Radchenko Date: Mon, 29 Dec 2025 20:59:27 +0200 Subject: [PATCH 4/7] ci: run playwright-kit bin in examples --- .github/workflows/check.yml | 3 +++ examples/next-admin-auth/package.json | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index c8331a2..9e449e3 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -59,6 +59,9 @@ jobs: - name: Build workspace run: npm run build + - name: Verify playwright-kit CLI + run: ./node_modules/.bin/playwright-kit --help + - name: Install Playwright browsers run: npx playwright install --with-deps diff --git a/examples/next-admin-auth/package.json b/examples/next-admin-auth/package.json index fad9c98..99fca28 100644 --- a/examples/next-admin-auth/package.json +++ b/examples/next-admin-auth/package.json @@ -5,7 +5,7 @@ "dev": "next dev -p 3017", "build": "next build", "start": "next start -p 3017", - "auth:ensure": "npm exec playwright-kit -- auth ensure --dotenv", + "auth:ensure": "playwright-kit auth ensure --dotenv", "pretest": "npm run auth:ensure", "test": "playwright test" }, From 30a82b5d2fc10e6fcabf140ad84e42fcd5495b33 Mon Sep 17 00:00:00 2001 From: Roman Radchenko Date: Mon, 29 Dec 2025 21:02:19 +0200 Subject: [PATCH 5/7] ci: verify playwright-kit via workspace --- .github/workflows/check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 9e449e3..cd0a26e 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -60,7 +60,7 @@ jobs: run: npm run build - name: Verify playwright-kit CLI - run: ./node_modules/.bin/playwright-kit --help + run: npm -w examples/next-admin-auth exec -- playwright-kit --help - name: Install Playwright browsers run: npx playwright install --with-deps From 6f233fcb196e98a957d6d01d6004745375954b71 Mon Sep 17 00:00:00 2001 From: Roman Radchenko Date: Mon, 29 Dec 2025 21:04:16 +0200 Subject: [PATCH 6/7] ci: run unit tests only --- .github/workflows/check.yml | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index cd0a26e..8931259 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -56,14 +56,5 @@ jobs: - name: Install dependencies run: npm ci - - name: Build workspace - run: npm run build - - - name: Verify playwright-kit CLI - run: npm -w examples/next-admin-auth exec -- playwright-kit --help - - - name: Install Playwright browsers - run: npx playwright install --with-deps - - - name: Test - run: npm run test + - name: Test (unit) + run: npm run test:unit From 0c982dc48c11ed54ad5cce12e0bf1887307fd4c5 Mon Sep 17 00:00:00 2001 From: Roman Radchenko Date: Mon, 29 Dec 2025 21:06:23 +0200 Subject: [PATCH 7/7] ci: build and run unit tests --- .github/workflows/check.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 8931259..4c55f91 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -40,8 +40,11 @@ jobs: - name: Install dependencies run: npm ci + - name: Build + run: npm run build + - name: Typecheck - run: npm run typecheck + run: npm -w packages/auth run typecheck test: runs-on: ubuntu-latest