🐛 Fix open URL in Firefox (#7)

Author: roniemartinez

browsers/__init__.py

@@ -104,11 +104,14 @@ def launch(browser: str, url: str, args: Optional[Sequence[str]] = None) -> None
     if not b:
         logger.info("Cannot find browser '%s'", browser)
         return
-    _launch(b["path"], url, args)
+    _launch(browser, b["path"], url, args)
 
 
-def _launch(path: str, url: str, args: Sequence[str]) -> None:  # pragma: no cover
-    command = [*shlex.split(path), url, "--args", *args]
+def _launch(browser: str, path: str, url: str, args: Sequence[str]) -> None:  # pragma: no cover
+    url_arg = [] if browser == "firefox" else [url]
+    if browser == "firefox":
+        args = ("-new-tab", url, *args)
+    command = [*shlex.split(path), *url_arg, "--args", *args]
     if sys.platform == "darwin":
         command = ["open", "--wait-apps", "--new", "--fresh", "-a", *command]
     subprocess.Popen(command)

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "pybrowsers"
-version = "0.1.0-alpha.3"
+version = "0.1.0-alpha.4"
 repository = "https://github.com/roniemartinez/browsers"
 description = "Python library for detecting and launching browsers"
 authors = ["Ronie Martinez <ronmarti18@gmail.com>"]

tests/test_detect.py

@@ -114,7 +114,7 @@ def test_get(browser: str, details: Dict) -> None:
 @mock.patch.object(browsers, "_launch")
 def test_launch(mock_launch: mock.MagicMock, chrome_path: str) -> None:
     browsers.launch("chrome", url="https://github.com/roniemartinez/browsers")
-    mock_launch.assert_called_with(chrome_path, "https://github.com/roniemartinez/browsers", [])
+    mock_launch.assert_called_with("chrome", chrome_path, "https://github.com/roniemartinez/browsers", [])
 
 
 @mock.patch.object(browsers, "_launch")