Use Integer#allbits? and Integer#nobits? for rubocop.

postmodern · postmodern · commit 02c341c3377a · 2024-11-18T20:34:33.000-08:00
diff --git a/lib/ronin/support/network/ip.rb b/lib/ronin/support/network/ip.rb
@@ -289,7 +289,7 @@ def self.extract(text,version=nil,&block)
         #
         def broadcast?
           # NOTE: IPv6 does not have broadcast addresses
-          ipv4? && (@addr & 0xff) == 0xff
+          ipv4? && @addr.allbits?(0xff) # IPv4: A.B.C.255
         end
 
         #
@@ -309,7 +309,7 @@ def broadcast?
         #   # => false
         #
         def logical?
-          ipv4? && (@addr & 0xff) == 0x00
+          ipv4? && @addr.nobits?(0xff) # IPv4: A.B.C.0
         end
 
         #

Original file line number	Diff line number	Diff line change
`@@ -289,7 +289,7 @@ def self.extract(text,version=nil,&block)`
`289`	`289`	`#`
`290`	`290`	`def broadcast?`
`291`	`291`	`# NOTE: IPv6 does not have broadcast addresses`
`292`		`- ipv4? && (@addr & 0xff) == 0xff`
	`292`	`+ ipv4? && @addr.allbits?(0xff) # IPv4: A.B.C.255`
`293`	`293`	`end`
`294`	`294`
`295`	`295`	`#`
`@@ -309,7 +309,7 @@ def broadcast?`
`309`	`309`	`# # => false`
`310`	`310`	`#`
`311`	`311`	`def logical?`
`312`		`- ipv4? && (@addr & 0xff) == 0x00`
	`312`	`+ ipv4? && @addr.nobits?(0xff) # IPv4: A.B.C.0`
`313`	`313`	`end`
`314`	`314`
`315`	`315`	`#`