From b1c5398b6ab31d6d434d3e85efa8e82c39132919 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20V=C3=B6lkle?= Date: Thu, 5 Oct 2023 21:08:23 +0200 Subject: [PATCH 1/3] update github actions --- .github/workflows/R-CMD-check.yaml | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml index c929998..84ae28b 100644 --- a/.github/workflows/R-CMD-check.yaml +++ b/.github/workflows/R-CMD-check.yaml @@ -1,4 +1,4 @@ -# Workflow derived from https://github.com/r-lib/actions/tree/master/examples +# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples # Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help on: workflow_dispatch: @@ -36,17 +36,20 @@ jobs: image: juyeongkim/test-server steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - - uses: r-lib/actions/setup-r@v1 + - uses: r-lib/actions/setup-r@v2 with: use-public-rspm: true - - uses: r-lib/actions/setup-r-dependencies@v1 + - uses: r-lib/actions/setup-r-dependencies@v2 with: - extra-packages: rcmdcheck + extra-packages: any::rcmdcheck + needs: check - - uses: r-lib/actions/check-r-package@v1 + - uses: r-lib/actions/check-r-package@v2 + with: + upload-snapshots: true env: SELENIUM_BROWSER: ${{ matrix.browser }} TEST_SERVER: http://test-server:8080 From 3c90c3fa510cf8c1eea5edd27f37230be65ebca7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20V=C3=B6lkle?= Date: Thu, 5 Oct 2023 21:30:06 +0200 Subject: [PATCH 2/3] fix expected error message --- tests/testthat/test-errorHandler.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testthat/test-errorHandler.R b/tests/testthat/test-errorHandler.R index af14d7a..ff7cb62 100644 --- a/tests/testthat/test-errorHandler.R +++ b/tests/testthat/test-errorHandler.R @@ -5,7 +5,7 @@ test_that("canGetHttrError", { dumRD <- remoteDriver(port = 9999L) expect_error( dumRD$open(silent = TRUE), - "Undefined error in httr call. httr output: Failed to connect to localhost port 9999: Connection refused" + "Undefined error in httr call. httr output: Failed to connect to localhost port 9999 after 0ms: Connection refused" ) }) From 138fee8e33c8bd9c8791e8dfb16382504be7a175 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20V=C3=B6lkle?= Date: Thu, 5 Oct 2023 22:29:22 +0200 Subject: [PATCH 3/3] typo --- tests/testthat/test-errorHandler.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testthat/test-errorHandler.R b/tests/testthat/test-errorHandler.R index ff7cb62..9caeac5 100644 --- a/tests/testthat/test-errorHandler.R +++ b/tests/testthat/test-errorHandler.R @@ -5,7 +5,7 @@ test_that("canGetHttrError", { dumRD <- remoteDriver(port = 9999L) expect_error( dumRD$open(silent = TRUE), - "Undefined error in httr call. httr output: Failed to connect to localhost port 9999 after 0ms: Connection refused" + "Undefined error in httr call. httr output: Failed to connect to localhost port 9999 after 0 ms: Connection refused" ) })