Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict input to readline(prompt = "") #71

Closed
RayStick opened this issue Feb 5, 2024 · 2 comments · Fixed by #80
Closed

Restrict input to readline(prompt = "") #71

RayStick opened this issue Feb 5, 2024 · 2 comments · Fixed by #80
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@RayStick
Copy link
Contributor

RayStick commented Feb 5, 2024

Using readline(prompt = "Question? ") does not allow for specificity of what data type is given (e.g. text, single integer, comma seperated text or integers) as it reads everything in as a string.

At multiple points in the code the user is asked for a certain input but if they gave a different type, it would not always notice this is an invalid input. More validation checks on the input the user gives to every readline(prompt) is needed to avoid the code crashing and giving the user non-specific error message

@RayStick RayStick self-assigned this Feb 5, 2024
@RayStick RayStick added the bug Something isn't working label Feb 5, 2024
@RayStick RayStick added this to the Before 0.2.0 release milestone Feb 5, 2024
@RayStick RayStick added domain_mapping help wanted Extra attention is needed labels Feb 5, 2024
@Rainiefantasy Rainiefantasy self-assigned this Mar 6, 2024
@Rainiefantasy
Copy link
Collaborator

I think this captures what I mentioned in PR #67 I've assigned this to both of us for now and we can always decide who does what later :)

@RayStick
Copy link
Contributor Author

RayStick commented Apr 4, 2024

This looks like a helpful article: https://www.scaler.com/topics/user-input-in-r/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants