Skip to content

Commit 491a9c0

Browse files
committed
Add optional directive to RUN colcon test
1 parent 1ca8da5 commit 491a9c0

File tree

3 files changed

+28
-25
lines changed

3 files changed

+28
-25
lines changed

.dockerhub/distro.Dockerfile

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -88,15 +88,12 @@ RUN sed --in-place \
8888
's|^source .*|source "$OVERLAY_WS/install/setup.bash"|' \
8989
/ros_entrypoint.sh
9090

91-
# ARG RUN_TESTS
92-
# ARG FAIL_ON_TEST_FAILURE
93-
# RUN if [ -z "$RUN_TESTS" ]; then \
94-
# colcon test \
95-
# --mixin $OVERLAY_MIXINS \
96-
# --ctest-args --test-regex "test_.*"; \
97-
# if [ -z "$FAIL_ON_TEST_FAILURE" ]; then \
98-
# colcon test-result; \
99-
# else \
100-
# colcon test-result || true; \
101-
# fi \
102-
# fi
91+
ARG RUN_TESTS
92+
ARG FAIL_ON_TEST_FAILURE=Ture
93+
RUN if [ -n "$RUN_TESTS" ]; then \
94+
. $OVERLAY_WS/install/setup.sh && \
95+
colcon test \
96+
--mixin $OVERLAY_MIXINS \
97+
&& colcon test-result \
98+
|| ([ -z "$FAIL_ON_TEST_FAILURE" ] || exit 1) \
99+
fi

.dockerhub/source.Dockerfile

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -180,16 +180,12 @@ RUN sed --in-place \
180180
's|^source .*|source "$OVERLAY_WS/install/setup.bash"|' \
181181
/ros_entrypoint.sh
182182

183-
# # test overlay source
184-
# ARG RUN_TESTS
185-
# ARG FAIL_ON_TEST_FAILURE
186-
# RUN if [ ! -z "$RUN_TESTS" ]; then \
187-
# colcon test \
188-
# --packages-select \
189-
# $(cat src/overlay/packages.txt | xargs); \
190-
# if [ ! -z "$FAIL_ON_TEST_FAILURE" ]; then \
191-
# colcon test-result; \
192-
# else \
193-
# colcon test-result || true; \
194-
# fi \
195-
# fi
183+
ARG RUN_TESTS
184+
ARG FAIL_ON_TEST_FAILURE=Ture
185+
RUN if [ -n "$RUN_TESTS" ]; then \
186+
. $OVERLAY_WS/install/setup.sh && \
187+
colcon test \
188+
--mixin $OVERLAY_MIXINS \
189+
&& colcon test-result \
190+
|| ([ -z "$FAIL_ON_TEST_FAILURE" ] || exit 1) \
191+
fi

Dockerfile

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,3 +110,13 @@ ENV OVERLAY_WS $OVERLAY_WS
110110
RUN sed --in-place \
111111
's|^source .*|source "$OVERLAY_WS/install/setup.bash"|' \
112112
/ros_entrypoint.sh
113+
114+
ARG RUN_TESTS
115+
ARG FAIL_ON_TEST_FAILURE=Ture
116+
RUN if [ -n "$RUN_TESTS" ]; then \
117+
. $OVERLAY_WS/install/setup.sh && \
118+
colcon test \
119+
--mixin $OVERLAY_MIXINS \
120+
&& colcon test-result \
121+
|| ([ -z "$FAIL_ON_TEST_FAILURE" ] || exit 1) \
122+
fi

0 commit comments

Comments
 (0)