Skip to content

Scalar.h and Scalar.hpp have the same header guard in tf2/LinearMath #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philippewarren opened this issue Jan 16, 2025 · 2 comments
Closed

Scalar.h and Scalar.hpp have the same header guard in tf2/LinearMath #753

philippewarren opened this issue Jan 16, 2025 · 2 comments

Comments

@philippewarren
Copy link

Since #720, .h files where moved to equivalent .hpp files, and the tf2/LinearMath/Scalar files have the same header guard.
Since the only job of the .h now is to include the .hpp, using the .h directly never includes anything because of the shared header guard.

What should be a deprecation warning is instead a bunch of missing stuff creating a whole lot of errors.

This should be fixed to ease the migration to .hpp.

(Using 0.25.11 on Humble)
This was referenced Jan 17, 2025
Closed
Merged
@ahcorde
Copy link
Contributor

ahcorde commented Jan 17, 2025

PR is merged

@ahcorde ahcorde closed this as completed Jan 17, 2025
@ahcorde
Copy link
Contributor

ahcorde commented Jan 17, 2025

#755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tf2 headers humble fix CursedRock17/geometry2
2 participants
@ahcorde @philippewarren