Grade & Assignment 2 Feedback #2
Description
Grade: Check
Overall decent job on the assignment, there are a few structural issues around how the dash projectile was build and code could be simpler (see solutions from class) Here are some of the notes I took while reviewing:
- Convention is to use Cast instead of C++ casting for save casting (eg. line 33 of teleport projectile)
- TimerHandle should just be a variable inside of the projectile itself, and not be linked to character. This can greatly simplify the code.
- HitResult on line 36 isn't used anywhere.
- I'm glad you re-used the ability spawning logic. Consider giving the code in that function a bit more space so it's easier to read.
- timer of teleporting projectile should be inside the projectile class and not the character class. It can be bound easier as we've bound timers in class before instead of delegates and .bindufcuntion().
- idea of BindAction with additional parameter is interesting and does allow for more code-use.
- Consider changing how you bind all your timer events like we did in class, it's easier to read and doesn't allow for typos or issues with functions changing names.
- Blueprint looks good.
- All the elements are properly functional in-game.
The grade is check mainly due to the class design issues surrounding the dash projectile.