Skip to content

Assignment 6 Feedback #7

@bagamian-stanford

Description

@bagamian-stanford

Grade: ✓+

Comments:
Overall nice job on the assignment, few comments below.

  • Thorns should only affect instigator rather than owner (deals damage back to attacker)
  • Thorns should only affect instigator when damage decreases
  • "NewRage" isn't necessary in OnHealthChanged
  • Rage check and consumption shouldn't be in the Projectile class, it should be checked before the action starts - either be checked in the character or can override CanStart in the Blackhole action as shown in class

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions