Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log/Show the file size. #26

Open
rodrigograca31 opened this issue Jul 29, 2016 · 3 comments
Open

Log/Show the file size. #26

rodrigograca31 opened this issue Jul 29, 2016 · 3 comments

Comments

@rodrigograca31
Copy link

Hi!

I've used the plugin for a while and I always check the .apk file size to see if it's still "too big" after using the plugin....

So, I've made a little cordova hook that displays the .apk size....
https://gist.github.com/rodrigograca31/49f3cf066b21eb523c0e5085e145cd84

It's not perfect (as outlined in the comments)

It also opens the directory so that the person can drag it to the Play Store faster... (when using cordova build)

I would like to know if you guys could include part of my hook in this plugin to make it show the file size after building/running?

Thanks.

@rossmartin
Copy link
Owner

rossmartin commented Jul 31, 2016

Thanks I'll look into it. I rarely build a cordova app for android anymore so it may be awhile before I get to this. I don't think everyone uses the cordova CLI to generate a signed APK (they might use android studio).

Have you considered making your hook standalone and installable via npm?

@rodrigograca31
Copy link
Author

@rossmartin I've built dozens of apps and never used Android studio to sign them....
I've always used the CLI like this: http://ionicframework.com/docs/guide/publishing.html

I don't think people would install my hook if it was standalone just to see the .apk size...
That's why I thought about incorporate it into this tool...
Because people using this tool (cordova-uglify) are worried about the .apk size...

@rossmartin
Copy link
Owner

You're welcome to submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants