-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPIC: version 1.0.0 #7
Labels
Comments
A lot of ideas are here : #6 |
Let me summarize all the proposed modifications. I need 10 minutes.
I have some questions and notes.
…On Mon, Jan 30, 2017 at 5:51 PM, Maksim Koryukov ***@***.***> wrote:
A lot of ideas are here : #6
<#6>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB2IsXTO-532UQkMy-nR92zzY-vITIYxks5rXerJgaJpZM4Lxa8_>
.
|
pls ensure our notes and tasks are totally private
… On Jan 30, 2017, at 9:06 AM, Amazos ***@***.***> wrote:
Let me summarize all the proposed modifications. I need 10 minutes.
I have some questions and notes.
On Mon, Jan 30, 2017 at 5:51 PM, Maksim Koryukov ***@***.***>
wrote:
> A lot of ideas are here : #6
> <#6>
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#7 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AB2IsXTO-532UQkMy-nR92zzY-vITIYxks5rXerJgaJpZM4Lxa8_>
> .
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Proposed Modification Note / Question Todo action after modification
IMO the repo needs some polishing (naming consistency) maybe splitting
schemas into modules/folders related to a specific part of route4me
service, but that's not in the scope of this pull request. Are you offering
to create folders structure inspired by documentation topics structure? -
http://route4me.io/docs/ Do appropriate modfications in related materials
(java, GO, links in Route4Me SDK documentation
What could go into this PR is completely removing name property from
everywhere as it's not in the schema documentation, and AFAIK is useless
now due to it being the same as the parent property name. We can remove
names without problem
Another thought on the JSON schema is that it mixes http get parameters,
headers and json post bodies without any indication. Maybe resigning from
the get params and headers would be a good move (especially for
validation). What could be even better is splitting the schemas into json
and get parameters i.e. "addressbook_body.dtd" and "addressbook_url.dtd". This
point we should regard together with first point above. Do appropriate
modfications in related materials (java, GO, links in Route4Me SDK
documentation
The first and necessary step - use versioning. Each SDK will be bounded to
appropriate version of schemes-set, and certain SDK won't be broken when
somebody will modify schemes in this repository (on master branch) Good
idea, altough maintenance of the repos will be complicated. Do appropriate
modfications in related materials (java, GO, links in Route4Me SDK
documentation
On Mon, Jan 30, 2017 at 6:06 PM, Oleg Guchashvili <oleg.guchi@gmail.com>
wrote:
… Let me summarize all the proposed modifications. I need 10 minutes.
I have some questions and notes.
On Mon, Jan 30, 2017 at 5:51 PM, Maksim Koryukov ***@***.***
> wrote:
> A lot of ideas are here : #6
> <#6>
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#7 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AB2IsXTO-532UQkMy-nR92zzY-vITIYxks5rXerJgaJpZM4Lxa8_>
> .
>
|
I've replied;) in private doc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The power of this repo is not utilized for 100% , because this is just a set of examples.
Target: We should use its schemes for validation.
The first and necessary step - use versioning. Each SDK will be bounded to appropriate version of schemes-set, and certain SDK won't be broken when somebody will modify schemes in this repository (on master branch)
Lets discuss the other things, required for version 1.0.0 (and probably next versions)
The text was updated successfully, but these errors were encountered: