From 237133498e6d0bd9e14348aa87179c261b3128d6 Mon Sep 17 00:00:00 2001 From: Jordao Bragantini Date: Fri, 23 Jan 2026 10:33:24 -0800 Subject: [PATCH 1/2] fixing mask dtype bug --- src/tracksdata/nodes/_mask.py | 4 ++-- src/tracksdata/nodes/_test/test_mask.py | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/tracksdata/nodes/_mask.py b/src/tracksdata/nodes/_mask.py index ea3cc56e..6743d12a 100644 --- a/src/tracksdata/nodes/_mask.py +++ b/src/tracksdata/nodes/_mask.py @@ -26,10 +26,10 @@ def _nd_sphere( """ if ndim == 2: - return morph.disk(radius) + return morph.disk(radius).astype(bool) if ndim == 3: - return morph.ball(radius) + return morph.ball(radius).astype(bool) raise ValueError(f"Spherical is only implemented for 2D and 3D, got ndim={ndim}") diff --git a/src/tracksdata/nodes/_test/test_mask.py b/src/tracksdata/nodes/_test/test_mask.py index 6723dc44..82c99812 100644 --- a/src/tracksdata/nodes/_test/test_mask.py +++ b/src/tracksdata/nodes/_test/test_mask.py @@ -376,6 +376,7 @@ def test_mask_from_coordinates_2d_basic() -> None: # Should be a disk of radius 2, shape (5,5), centered at (5,5) assert mask.mask.shape == (5, 5) assert mask.mask[2, 2] # center pixel is True + assert mask.dtype == bool np.testing.assert_array_equal(mask.bbox, [3, 3, 8, 8]) From 589a51154c6354105afa50a9fd09d32adbad8baa Mon Sep 17 00:00:00 2001 From: Jordao Bragantini Date: Fri, 23 Jan 2026 11:27:39 -0800 Subject: [PATCH 2/2] fixing test --- src/tracksdata/nodes/_test/test_mask.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tracksdata/nodes/_test/test_mask.py b/src/tracksdata/nodes/_test/test_mask.py index 82c99812..d804f21d 100644 --- a/src/tracksdata/nodes/_test/test_mask.py +++ b/src/tracksdata/nodes/_test/test_mask.py @@ -376,7 +376,7 @@ def test_mask_from_coordinates_2d_basic() -> None: # Should be a disk of radius 2, shape (5,5), centered at (5,5) assert mask.mask.shape == (5, 5) assert mask.mask[2, 2] # center pixel is True - assert mask.dtype == bool + assert mask.mask.dtype == bool np.testing.assert_array_equal(mask.bbox, [3, 3, 8, 8])