Skip to content

Commit 45af79b

Browse files
committed
Remove some fixed FIXME's
1 parent 55174c2 commit 45af79b

File tree

5 files changed

+0
-9
lines changed

5 files changed

+0
-9
lines changed

Sqliteman/sqliteman/altertabledialog.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ For general Sqliteman copyright and licensing information please refer
33
to the COPYING file provided with the program. Following this notice may exist
44
a copyright and/or license notice that predates the release of Sqliteman
55
for which a new license (GPL+exception) is in place.
6-
FIXME icon-only widths, not removing column, up/down not altering
76
FIXME loses some constraints
87
multiple primary key are not allowed
98
multiple not null are allowed

Sqliteman/sqliteman/importtabledialog.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@ a copyright and/or license notice that predates the release of Sqliteman
55
for which a new license (GPL+exception) is in place.
66
77
FIXME handle column names in first row
8-
FIXME we seem to be importing twice
98
FIXME re-add Psion format
10-
FIXME deal with embedded newlines in CSV format
119
*/
1210
#include <QFileDialog>
1311
#include <QMessageBox>

Sqliteman/sqliteman/populatordialog.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ For general Sqliteman copyright and licensing information please refer
33
to the COPYING file provided with the program. Following this notice may exist
44
a copyright and/or license notice that predates the release of Sqliteman
55
for which a new license (GPL+exception) is in place.
6-
FIXME view not updating after populate
76
*/
87
#include <QSqlQuery>
98
#include <QSqlError>
@@ -275,8 +274,6 @@ QVariantList PopulatorDialog::autoValues(Populator::PopColumn c)
275274

276275
QVariantList PopulatorDialog::autoFromValues(Populator::PopColumn c)
277276
{
278-
// TODO/FIXME: possible string to number conversion error
279-
// It will need to change PopulatorColumnWidget behavior probably
280277
int min = c.userValue.toInt();
281278

282279
QVariantList ret;

Sqliteman/sqliteman/sqlparser.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ It contains a parser for SQL schemas (not general SQL statements). Since the
1010
schema is known to be valid, we do not detect all cases of bad syntax.
1111
1212
sqlite_master and describe table leave any quotes around types, but pragma table_info removes them.
13-
FIXME m_hasRowid is true when it shouldn't be
1413
*/
1514

1615
#include <QStringList>

Sqliteman/sqliteman/tableeditordialog.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ for which a new license (GPL+exception) is in place.
1414
#include "tableeditordialog.h"
1515
#include "utils.h"
1616

17-
//FIXME resizing window needs to set resizeWanted
18-
1917
TableEditorDialog::TableEditorDialog(LiteManWindow * parent)
2018
{
2119
creator = parent;

0 commit comments

Comments
 (0)