Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching tabs with a mobile device and ngTouch does not work #2

Closed
fdomig opened this issue Nov 10, 2014 · 3 comments
Closed

Switching tabs with a mobile device and ngTouch does not work #2

fdomig opened this issue Nov 10, 2014 · 3 comments

Comments

@fdomig
Copy link

fdomig commented Nov 10, 2014

When using ngTouch within the application, switching tabs does not work on mobile anymore. I am not sure if this is related to a bug in angular-touch itself or related to ui-router-tabs.

I have another jsfiddle example to demonstrate the behaviour.

Switching with the buttons within the tab is working, however, switching with the tab-headings is not.

@rpocklin
Copy link
Owner

Confirmed it's an issue on mobile / touch devices. Only having a brief look and research it sounds like ngTouch does something to ngClick events. I threw this up which works http://jsfiddle.net/g1k9vgok/9/ using the ng-touch-fix branch but not convinced it's the best route (lol) to go down.

Does this fiddle work for you now?

@fdomig
Copy link
Author

fdomig commented Nov 10, 2014

Thank you Robert for your very fast response. This does indeed fix this issue.

@rpocklin
Copy link
Owner

Great. I'll review this change and bump the release in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants