bug in (t_eff
, u_0
) parameterization for parallax models with negative u_0
#99
Labels
t_eff
, u_0
) parameterization for parallax models with negative u_0
#99
@przemekmroz informed me that he found bug in parallax calculation for model with
t_E
calculated fromt_eff
andu_0
for negativeu_0
.Trajectory
callsModelParameters.t_E
for tau calculation. For this parameterization,ModelParameters.t_E
returnsself.t_eff / self.u_0
, which is negative. We should addmath.abs()
in denominator or make a similar change. Other similar cases should be considered (e.g.,t_E_1/2
for binary source models).The text was updated successfully, but these errors were encountered: