Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not full screen in 6 plus/6s plus #23

Open
ljfdestiny opened this issue Mar 3, 2016 · 2 comments
Open

can not full screen in 6 plus/6s plus #23

ljfdestiny opened this issue Mar 3, 2016 · 2 comments

Comments

@ljfdestiny
Copy link

When using 6 plus and 6s plus(Device) render in VR mode can not full screen, any idea of it?

@ericgouldbear
Copy link

We've found a similar problem and would appreciate some guidance in solving. In our publicly-available app, Walk-in Theater, iPhone 6+ draws VR mode fine, utilizing full height and width of the screen. iPhone 6S+, however, draws eyeFrames in a smaller region of the screen -- as if it is a 6/6S-sized screen inside a 6S+. There is extra black above and to the left and right of the eyeFrames. No problem drawing to the rest of the screen outside CardboardSDK-iOS, as you can see from compass in bottom-left of 6S+ screenshot below.

Anyone else getting this result? Would love some creative suggestions on how to open those eyes up to the full screen on 6S+ to match 6+ experience. Thanks!

iPhone 6S+:
img_0717

iPhone 6+:
img_8186

@rsanchezsaez
Copy link
Owner

I think you need to add the iPhone 6s, iPhone 6s+ and iPhone SE product codes to this list. It'd be good to take the chance and add all the new iPads too.

Also, double check that these two macros continue to work with the iPhone 6s+.

Can somebody check if this fixes the problem? If it does, I'll be glad to accept a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants