Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dplyr 1.0.6 #130

Open
romainfrancois opened this issue Apr 22, 2021 · 1 comment
Open

dplyr 1.0.6 #130

romainfrancois opened this issue Apr 22, 2021 · 1 comment

Comments

@romainfrancois
Copy link

I'm seeing this when I test DAISIE against the release candidate of dplyr 1.0.6:

══ Reverse dependency check ══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════ DAISIE 3.0.1 ══

Status: BROKEN

── Still failing

x checking package dependencies ... NOTE

── Newly failing

x checking examples ... ERROR

── Before ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
> checking package dependencies ... NOTE
  Package which this enhances but not available for checking: ‘doMC’

0 errors ✓ | 0 warnings ✓ | 1 note x

── After ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
> checking examples ... ERROR
  Running examples in ‘DAISIE-Ex.R’ failed
  The error most likely occurred in:
  
  > ### Name: DAISIE_plot_input
  > ### Title: DAISIE tree plot
  > ### Aliases: DAISIE_plot_input
  > 
  > ### ** Examples
  > 
  > 
  >  # check whether package tibble has been installed
  >  if (!requireNamespace('tibble', quietly = TRUE)) {
  +     cat("Package tibble needed for this function to work. Please install it.")
  +  } else {
  +  set.seed(42)
  + 
  +  # Random trees
  +  t1 <- ape::rtree(10)
  +  t1$tip.label <- gsub("t", "t1.", t1$tip.label)
  +  t2 <- ape::rtree(3)
  +  t2$tip.label <- gsub("t", "t2.", t2$tip.label)
  +  t3 <- DAISIE:::DAISIE_single_branch(
  +    "t3.1",
  +    edge.length = 4.6
  +  ) # tree with one species
  +  trees <- list(t1, t2, t3)
  +  names(trees) <- c("A", "B", "C")
  + 
  +  # Toy colonization events for each clade
  +  tcols <- c(4.5, 5, 4.6)
  + 
  +  # Toy metadata
  +  metadata <- tibble::tibble(
  +    clade = names(trees),
  +    endemic = TRUE,  # whether each clade is endemic
  +    uncertain = FALSE  # whether colonization time is known for sure
  +  )
  +  metadata$endemic[3] <- FALSE
  +  metadata$uncertain[2] <- TRUE
  + 
  +  # Island age
  +  age <- 5
  + 
  +  # Make a plot
  +  p <- DAISIE_plot_input(
  +    trees,
  +    age,
  +    tcols,
  +    metadata,
  +    mapping = ggplot2::aes(color = endemic, linetype = uncertain),
  +    pargs = list(size = 3)
  +  )
  + p
  + }
  Error in DataMask$new(.data, caller_env) : 
    argument "caller_env" is missing, with no default
  Calls: DAISIE_plot_input ... mutate.data.frame -> mutate_cols -> <Anonymous> -> initialize
  Execution halted

> checking package dependencies ... NOTE
  Package which this enhances but not available for checking: ‘doMC’

1 error x | 0 warnings ✓ | 1 note x

But so far I have failed to test locally. Initially here: tidyverse/dplyr#5810

@Neves-P
Copy link
Collaborator

Neves-P commented Apr 22, 2021

Hi @romainfrancois, thanks so much for the heads-up and for reporting this!
We'll look into it and hopefully solve it soon. Will post updates on this issue as things progress 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants