Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider more evident default parameters #96

Open
Neves-P opened this issue Mar 18, 2020 · 0 comments
Open

Consider more evident default parameters #96

Neves-P opened this issue Mar 18, 2020 · 0 comments

Comments

@Neves-P
Copy link
Collaborator

Neves-P commented Mar 18, 2020

Quoting @richelbilderbeek #90:

nonoceanic_pars = c(0, 0),

I see why this value is chosen: I predict there are two nonoceanic_pars,
that have no effect for values of zero. I would prefer an NA here,
because it does look needlessly complex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Neves-P