-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename labelOptions
to tooltipOptions
#511
Comments
I would suggest to also add (mention) the 'sticky'-parameter within the label option documentation. In the previous version, it was the default that the tooltip of a polygon follows the mouse cursor. Now it must be activated via |
@MatthiasHinz Was |
The behaviour of the tooltip following the mouse was the default behaviour in the leaflet R package before. I don not know whether it also was in leafletjs. See also my comment here - bullet 3. In my opinion it make more sense for the tooltip to be displayed at the mouse cursor than at some location representing the "center" of a feature. |
I completely agree with following the mouse vs "center" for a default. The jarring feeling I get when it doesn't show up at my mouse is worth going against the default leaflet.js setting. @tim-salabim Should the |
Yes, i think that is a good idea. |
|
With the adoption of Leaflet.label into
L.tooltip
, if we'd like to copy the names fully, we should rename labelOptions (function and argument usage) to tooltipOptions.This will probably involve deprecation / message functionality within the package.
Or (current implementation) we could leave as is and not change our api, but just point to the documentation of tooltip options from our labelOptions documentation.
leaflet/R/layers.R
Line 548 in bfe4b0d
The text was updated successfully, but these errors were encountered: