Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class names are not escaped #589

Open
ktosiek opened this issue Aug 15, 2023 · 0 comments
Open

Class names are not escaped #589

ktosiek opened this issue Aug 15, 2023 · 0 comments

Comments

@ktosiek
Copy link

ktosiek commented Aug 15, 2023

Passing a class name that contains "/" (or any character that is special in CSS) works in an unexpected way. This two classes won't match, even tough they are specified with the exact same string:

[ global
    [ Css.Global.class "my/class" [ color red ] ]
, div [ class "my/class" ] [ text "I should be red" ]
]

It seems that names passed into Css.Global.class are handled as raw CSS fragments, not actual class names.

Is there any way this could be fixed? I understand it would be a bit backwards-incompatible, as people might already escape the names (or even pass complex selectors to class).

I've prepared an Ellie with a working example. The counter should be centered, and should not have a dashed border: https://ellie-app.com/nFkBH6KXwLqa1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant