-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure with dev glue #77
Comments
Before I rolled back / postponed this change in glue, here's what I saw in my revdep checks for codebook: |
I released glue 1.7.0 today without this change and then re-introduced the change. So you can expect it to be present in glue's next release, which I have no concrete plans for. But barring an unforeseen release in the next ~2 weeks, I will consider this issue as me having given plenty of notice of the change. This also means you can check your package in the presence of dev glue to test your own fix for the issue. |
glue 1.8.0 has been accepted on CRAN now. |
closed in 0.9.5 sorry for the delay |
This issue is inspired by doing revdep checks for glue. I'm going to temporarily back off on the associated change in glue, just so I can release without any breakage of other packages.
But please do consider this a heads up that, in the future,
glue::glue()
will error when.envir
is not an actual environment..envir
has always been documented to be an environment and I'd like to make that actually true.OTOH
glue_data()
does officially accept something "list-ish" as.x
. So chances are you should switch toglue_data(.x = list_ish_thing, ...)
as opposed toglue(.envir = list_ish_thing, ...)
in one or more places here in this package.I started to see if I could make a PR for you, but I couldn't get codebook's dev deps installed:
Backstory in glue:
tidyverse/glue#308
tidyverse/glue@e2b74ff
The text was updated successfully, but these errors were encountered: