Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure with dev glue #77

Closed
jennybc opened this issue Dec 21, 2023 · 4 comments
Closed

Failure with dev glue #77

jennybc opened this issue Dec 21, 2023 · 4 comments

Comments

@jennybc
Copy link

jennybc commented Dec 21, 2023

This issue is inspired by doing revdep checks for glue. I'm going to temporarily back off on the associated change in glue, just so I can release without any breakage of other packages.

But please do consider this a heads up that, in the future, glue::glue() will error when .envir is not an actual environment. .envir has always been documented to be an environment and I'd like to make that actually true.

OTOH glue_data() does officially accept something "list-ish" as .x. So chances are you should switch to glue_data(.x = list_ish_thing, ...) as opposed to glue(.envir = list_ish_thing, ...) in one or more places here in this package.

I started to see if I could make a PR for you, but I couldn't get codebook's dev deps installed:

> pak::pak()
✔ Updated metadata database: 3.06 MB in 6 files.                           
ℹ R 4.3 aarch64-apple-darwin20 packages are missing from Bioconductor       
✔ Updating metadata database ... done                                      
Error:                                                                     
! error in pak subprocess
Caused by error: 
! Could not solve package dependencies:
* deps::/Users/jenny/rrr/codebook: Can't install dependency userfriendlyscience
* userfriendlyscience: Can't find package called userfriendlyscience.

Backstory in glue:

tidyverse/glue#308
tidyverse/glue@e2b74ff

@jennybc
Copy link
Author

jennybc commented Dec 21, 2023

Before I rolled back / postponed this change in glue, here's what I saw in my revdep checks for codebook:

https://github.com/tidyverse/glue/blob/c98f106c420d658da8010627d4a2a4d19f97d758/revdep/problems.md#codebook

@jennybc
Copy link
Author

jennybc commented Jan 10, 2024

I released glue 1.7.0 today without this change and then re-introduced the change. So you can expect it to be present in glue's next release, which I have no concrete plans for. But barring an unforeseen release in the next ~2 weeks, I will consider this issue as me having given plenty of notice of the change.

This also means you can check your package in the presence of dev glue to test your own fix for the issue.

@jennybc
Copy link
Author

jennybc commented Sep 30, 2024

glue 1.8.0 has been accepted on CRAN now.

@rubenarslan
Copy link
Owner

closed in 0.9.5 sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants