Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sv_XXXX namespace to appropriate function calls. #5

Open
FaultyPine opened this issue Jul 18, 2020 · 0 comments
Open

Add sv_XXXX namespace to appropriate function calls. #5

FaultyPine opened this issue Jul 18, 2020 · 0 comments

Comments

@FaultyPine
Copy link

FaultyPine commented Jul 18, 2020

Currently, all functions from a sv_XXXX namespace are displayed like so:
image
And when copy-pasting code from the data viewer into our Rust macro, we need to manually prepend sv_module_access:: (or whatever the namespace is) to those appropriate lines. It would be very beneficial to display that namespace name before those functions calls outright to not only work better with the Rust macro, but also to generally help with readability of the ACMD code in the data viewer.
Just having grab isn't a very self-explanatory of what the function is, but having the sv_module_access namespace before it gives a better clue as to where/what the function is.

This would preferably apply to all sv_XXX namespace functions EXCEPT sv_animcmd ONES. This is to maintain compatibility with the Rust macro.
If this was to be fixed, all that would need to happen is to have function calls from the sv_XXXX namespace show up like so:

sv_module_access::function_name(blah, blah, blah)
sv_system::battle_object()

Examples of these situations can found in the following:
For sv_module_access, any Catch script will use sv_module_access::grab
Hero's AttackS4 contains a sv_system::battle_object call

@FaultyPine FaultyPine changed the title Add sv_module_access namespace to appropriate function calls. Add sv_XXXX namespace to appropriate function calls. Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant