Skip to content

Don't use inner HTML when using attribute #146

@karelbilek

Description

@karelbilek

I want to translate custom annotation, as described here

https://angular-gettext.rocketeer.be/dev-guide/custom-annotations/

I have tooltip, I want to automatically translate it that way. HOWEVER, it is only used in pairwise tags. Like this:

<div tooltip="You have mouse on Foo!"><img src="http://example.org/foo.jpg">...</div>

However, I cannot do that. Once I add tooltip to attributes, the inner HTML is extracted.

It's probably because here - https://github.com/rubenv/angular-gettext-tools/blob/master/lib/extract.js#L345 - the logic is first take inner HTML, and only when it's falsey, take the argument.

That's very unfortunate. If you really want this behaviour, it should be documented.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions