diff --git a/CHANGELOG.md b/CHANGELOG.md index a79d4912a0..f79408fa8e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,32 @@ ## master (unreleased) +### New features + +* [#325](https://github.com/rubocop/rubocop-rails/pull/325): Add new `Rails/DotSeparatedKeys` cop. ([@fatkodima][]) +* [#704](https://github.com/rubocop/rubocop-rails/issues/704): Add new `Rails/StripHeredoc` cop. ([@koic][]) +* [#691](https://github.com/rubocop/rubocop-rails/pull/691): Add new `Rails/ToFormattedS` cop. ([@koic][]) +* [#588](https://github.com/rubocop/rubocop-rails/pull/588): Add new `Rails/RootPublicPath` cop. ([@leoarnold][]) +* [#702](https://github.com/rubocop/rubocop-rails/pull/702): Make `keys` method aware of `Rails/DeprecatedActiveModelErrorsMethods` cop. ([@koic][]) +* [#688](https://github.com/rubocop/rubocop-rails/pull/688): Support autocorrection for `Rails/DeprecatedActiveModelErrorsMethods`. ([@koic][]) + +### Bug fixes + +* [#696](https://github.com/rubocop/rubocop-rails/pull/696): Fix a false negative for `Rails/TransactionExitStatement` when `return` is used in `rescue`. ([@koic][]) +* [#700](https://github.com/rubocop/rubocop-rails/issues/700): Fix a false positive for `Rails/FilePath` when a list of paths separated by colon including Rails.root. ([@tk0miya][]) +* [#680](https://github.com/rubocop/rubocop-rails/issues/680): Fix a false positive for `Rails/ReversibleMigrationMethodDefinition` when using an inner class. ([@koic][]) +* [#692](https://github.com/rubocop/rubocop-rails/issues/692): Fix an error for `Rails/UnusedIgnoredColumns` when using no tables db/schema.rb. ([@koic][]) +* [#707](https://github.com/rubocop/rubocop-rails/issues/707): Fix an error when a variable is passed to has_many or has_one with double splat. ([@nobuyo][]) +* [#695](https://github.com/rubocop/rubocop-rails/pull/695): Fixes a false negative where the `in_rescue?` check would bypass situations where the return was inside a transaction but outside of a rescue. ([@dorkrawk][]) +* [#703](https://github.com/rubocop/rubocop-rails/pull/703): Fix not autocorrected for `Rails/DuplicateAssociation`. ([@ydah][]) +* [#708](https://github.com/rubocop/rubocop-rails/pull/708): Recover Ruby 2.2 code analysis using `TargetRubyVersion: 2.2`. ([@koic][]) + +### Changes + +* [#697](https://github.com/rubocop/rubocop-rails/pull/697): **(Compatibility)** Drop Ruby 2.5 support. ([@koic][]) +* [#705](https://github.com/rubocop/rubocop-rails/pull/705): Add mailers to default `filter`/`action` callbacks cops. ([@ojab][]) +* [#710](https://github.com/rubocop/rubocop-rails/pull/710): Rails/TransactionExitStatement - Inspect `ActiveRecord::Locking::Pessimistic#with_lock` too, as `#with_lock` opens a transaction. ([@FunnyHector][]) + ## 2.14.2 (2022-03-18) ### Bug fixes @@ -590,3 +616,8 @@ [@lulalala]: https://github.com/lulalala [@gmcgibbon]: https://github.com/gmcgibbon [@FunnyHector]: https://github.com/FunnyHector +[@ojab]: https://github.com/ojab +[@tk0miya]: https://github.com/tk0miya +[@nobuyo]: https://github.com/nobuyo +[@dorkrawk]: https://github.com/dorkrawk +[@ydah]: https://github.com/ydah diff --git a/changelog/change_drop_ruby_2_5_support.md b/changelog/change_drop_ruby_2_5_support.md deleted file mode 100644 index 0ea6528c60..0000000000 --- a/changelog/change_drop_ruby_2_5_support.md +++ /dev/null @@ -1 +0,0 @@ -* [#697](https://github.com/rubocop/rubocop-rails/pull/697): **(Compatibility)** Drop Ruby 2.5 support. ([@koic][]) diff --git a/changelog/change_enable_action_filter_cop_for_jobs_and_mailers.md b/changelog/change_enable_action_filter_cop_for_jobs_and_mailers.md deleted file mode 100644 index 8a31f83c15..0000000000 --- a/changelog/change_enable_action_filter_cop_for_jobs_and_mailers.md +++ /dev/null @@ -1 +0,0 @@ -* [#705](https://github.com/rubocop/rubocop-rails/pull/705): Add mailers to default `filter`/`action` callbacks cops. ([@ojab][]) diff --git a/changelog/change_inspect_with_lock_for_rails_transaction_exit_statement_cop.md b/changelog/change_inspect_with_lock_for_rails_transaction_exit_statement_cop.md deleted file mode 100644 index 1001051109..0000000000 --- a/changelog/change_inspect_with_lock_for_rails_transaction_exit_statement_cop.md +++ /dev/null @@ -1 +0,0 @@ -* [#710](https://github.com/rubocop/rubocop-rails/pull/710): Rails/TransactionExitStatement - Inspect `ActiveRecord::Locking::Pessimistic#with_lock` too, as `#with_lock` opens a transaction. ([@FunnyHector][]) diff --git a/changelog/fix_a_false_negative_for_rails_transaction_exit_statement.md b/changelog/fix_a_false_negative_for_rails_transaction_exit_statement.md deleted file mode 100644 index b9e1bec01b..0000000000 --- a/changelog/fix_a_false_negative_for_rails_transaction_exit_statement.md +++ /dev/null @@ -1 +0,0 @@ -* [#696](https://github.com/rubocop/rubocop-rails/pull/696): Fix a false negative for `Rails/TransactionExitStatement` when `return` is used in `rescue`. ([@koic][]) diff --git a/changelog/fix_a_false_positive_for_rails_filepath_for_colon_separated_pathlist.md b/changelog/fix_a_false_positive_for_rails_filepath_for_colon_separated_pathlist.md deleted file mode 100644 index 054afda625..0000000000 --- a/changelog/fix_a_false_positive_for_rails_filepath_for_colon_separated_pathlist.md +++ /dev/null @@ -1 +0,0 @@ -* [#700](https://github.com/rubocop/rubocop-rails/issues/700): Fix a false positive for `Rails/FilePath` when a list of paths separated by colon including Rails.root. ([@tk0miya][]) diff --git a/changelog/fix_a_false_positive_for_rails_reversible_migration_method_definition.md b/changelog/fix_a_false_positive_for_rails_reversible_migration_method_definition.md deleted file mode 100644 index 53ab0e81cd..0000000000 --- a/changelog/fix_a_false_positive_for_rails_reversible_migration_method_definition.md +++ /dev/null @@ -1 +0,0 @@ -* [#680](https://github.com/rubocop/rubocop-rails/issues/680): Fix a false positive for `Rails/ReversibleMigrationMethodDefinition` when using an inner class. ([@koic][]) diff --git a/changelog/fix_an_error_for_rails_unused_ignored_columns.md b/changelog/fix_an_error_for_rails_unused_ignored_columns.md deleted file mode 100644 index 960b1880f4..0000000000 --- a/changelog/fix_an_error_for_rails_unused_ignored_columns.md +++ /dev/null @@ -1 +0,0 @@ -* [#692](https://github.com/rubocop/rubocop-rails/issues/692): Fix an error for `Rails/UnusedIgnoredColumns` when using no tables db/schema.rb. ([@koic][]) diff --git a/changelog/fix_an_error_when_a_variable_is_passed.md b/changelog/fix_an_error_when_a_variable_is_passed.md deleted file mode 100644 index 343929db91..0000000000 --- a/changelog/fix_an_error_when_a_variable_is_passed.md +++ /dev/null @@ -1 +0,0 @@ -* [#707](https://github.com/rubocop/rubocop-rails/issues/707): Fix an error when a variable is passed to has_many or has_one with double splat. ([@nobuyo][]) diff --git a/changelog/fix_false_negative_for_transaction_exit_with_rescue.md b/changelog/fix_false_negative_for_transaction_exit_with_rescue.md deleted file mode 100644 index c9ecc3368d..0000000000 --- a/changelog/fix_false_negative_for_transaction_exit_with_rescue.md +++ /dev/null @@ -1 +0,0 @@ -* [#695](https://github.com/rubocop/rubocop-rails/pull/695): Fixes a false negative where the `in_rescue?` check would bypass situations where the return was inside a transaction but outside of a rescue. ([@dorkrawk][]) diff --git a/changelog/fix_not_autocrrected_for_rails_duplicate_association.md b/changelog/fix_not_autocrrected_for_rails_duplicate_association.md deleted file mode 100644 index 22ab3511df..0000000000 --- a/changelog/fix_not_autocrrected_for_rails_duplicate_association.md +++ /dev/null @@ -1 +0,0 @@ -* [#703](https://github.com/rubocop/rubocop-rails/pull/703): Fix not autocorrected for `Rails/DuplicateAssociation`. ([@ydah][]) diff --git a/changelog/fix_recover_ruby_22_code_analysis.md b/changelog/fix_recover_ruby_22_code_analysis.md deleted file mode 100644 index 66ba2059e2..0000000000 --- a/changelog/fix_recover_ruby_22_code_analysis.md +++ /dev/null @@ -1 +0,0 @@ -* [#708](https://github.com/rubocop/rubocop-rails/pull/708): Recover Ruby 2.2 code analysis using `TargetRubyVersion: 2.2`. ([@koic][]) diff --git a/changelog/new_add_new_dot_separated_keys_cop.md b/changelog/new_add_new_dot_separated_keys_cop.md deleted file mode 100644 index 6a91b47d7f..0000000000 --- a/changelog/new_add_new_dot_separated_keys_cop.md +++ /dev/null @@ -1 +0,0 @@ -* [#325](https://github.com/rubocop/rubocop-rails/pull/325): Add new `Rails/DotSeparatedKeys` cop. ([@fatkodima][]) diff --git a/changelog/new_add_new_rails_strip_heredoc_cop.md b/changelog/new_add_new_rails_strip_heredoc_cop.md deleted file mode 100644 index 6bf5fcfc43..0000000000 --- a/changelog/new_add_new_rails_strip_heredoc_cop.md +++ /dev/null @@ -1 +0,0 @@ -* [#704](https://github.com/rubocop/rubocop-rails/issues/704): Add new `Rails/StripHeredoc` cop. ([@koic][]) diff --git a/changelog/new_add_new_rails_to_formatted_s_cop.md b/changelog/new_add_new_rails_to_formatted_s_cop.md deleted file mode 100644 index 1998d56ad2..0000000000 --- a/changelog/new_add_new_rails_to_formatted_s_cop.md +++ /dev/null @@ -1 +0,0 @@ -* [#691](https://github.com/rubocop/rubocop-rails/pull/691): Add new `Rails/ToFormattedS` cop. ([@koic][]) diff --git a/changelog/new_add_new_railsrootpublicpath_cop.md b/changelog/new_add_new_railsrootpublicpath_cop.md deleted file mode 100644 index 0962442195..0000000000 --- a/changelog/new_add_new_railsrootpublicpath_cop.md +++ /dev/null @@ -1 +0,0 @@ -* [#588](https://github.com/rubocop/rubocop-rails/pull/588): Add new `Rails/RootPublicPath` cop. ([@leoarnold][]) diff --git a/changelog/new_make_keys_method_aware_of_rails_deprecated_active_model_errors_methods.md b/changelog/new_make_keys_method_aware_of_rails_deprecated_active_model_errors_methods.md deleted file mode 100644 index 8fdc3265d7..0000000000 --- a/changelog/new_make_keys_method_aware_of_rails_deprecated_active_model_errors_methods.md +++ /dev/null @@ -1 +0,0 @@ -* [#702](https://github.com/rubocop/rubocop-rails/pull/702): Make `keys` method aware of `Rails/DeprecatedActiveModelErrorsMethods` cop. ([@koic][]) diff --git a/changelog/new_support_autocorrect_for_rails_deprecated_active_model_errors_methods.md b/changelog/new_support_autocorrect_for_rails_deprecated_active_model_errors_methods.md deleted file mode 100644 index 3d8717d171..0000000000 --- a/changelog/new_support_autocorrect_for_rails_deprecated_active_model_errors_methods.md +++ /dev/null @@ -1 +0,0 @@ -* [#688](https://github.com/rubocop/rubocop-rails/pull/688): Support autocorrection for `Rails/DeprecatedActiveModelErrorsMethods`. ([@koic][])