Refactor RegistrationsControllerConcern.verify_passkey_registration_challenge to break out credential integrity verification into its own before_action

[tcannonfodder]

In #29, we refactored PasskeysControllerConcern.verify_passkey_challenge to move the integrity checks into their own before action: f1400cb (discussion where the idea came from: #29 (comment))

For consistency, we should have a similar pattern for RegistrationsControllerConcern.verify_passkey_registration_challenge. This will also involve updating the tests themselves to reflect the changes. See:

• https://github.com/ruby-passkeys/devise-passkeys/blob/main/lib/devise/passkeys/controllers/registrations_controller_concern.rb#L109
• https://github.com/ruby-passkeys/devise-passkeys/blob/2023-06-23-refactor-to-use-webauthn-rack-helpers/lib/devise/passkeys/controllers/passkeys_controller_concern.rb#L102
• https://github.com/ruby-passkeys/devise-passkeys/blob/2023-06-23-refactor-to-use-webauthn-rack-helpers/test/devise/passkeys/controllers/test_registrations_controller_concern.rb#L206
• https://github.com/ruby-passkeys/devise-passkeys/blob/2023-06-23-refactor-to-use-webauthn-rack-helpers/test/devise/passkeys/controllers/test_passkeys_controller_concern.rb#L298

@johalloran01 this might be a good issue to tackle as well, if you want to take it 💪

[Vagab]

I’ll take it on

[tcannonfodder]

@Vagab I definitely appreciate the gusto, but please wait for @johalloran01 to decide if it’s a project he’d like to tackle first. I’m helping him with mentoring/apprenticing; and trying to give him real-world issues to tackle as part of that process 😊

[johalloran01]

@tcannonfodder Thanks for looking out, I want work on the other three tasks first then I would love to look at the solution. @Vagab you're clear for this if you wish to take it! 👍

[Vagab]

sure, my pleasure

[Vagab]

@tcannonfodder a bit swamped at work currently, sorry if I mislead anyone. If someone wants to take this issue - feel free. Otherwise, I'll work on it in a week or two.

[tcannonfodder]

No worries! I know OSS work is free/spare time stuff; and I’ve been there before too numerous times. :) Just glad you’ve been able to help contribute so far! 💪