Separate RSTRING_PTR from a function call

nobu · hsbt · commit 07bd1c4e309d · 2019-01-07T13:56:42.000+09:00
Do not apply RSTRING_PTR, a macro which evaluats its argument
multiple times, on a function call.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66377 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
diff --git a/ext/date/date_core.c b/ext/date/date_core.c
@@ -6661,7 +6661,9 @@ tmx_m_of(union DateData *x)
 static char *
 tmx_m_zone(union DateData *x)
 {
-    return RSTRING_PTR(m_zone(x));
+    VALUE zone = m_zone(x);
+    /* TODO: fix potential dangling pointer */
+    return RSTRING_PTR(zone);
 }
 
 static const struct tmx_funcs tmx_funcs = {

Original file line number	Diff line number	Diff line change
`@@ -6661,7 +6661,9 @@ tmx_m_of(union DateData *x)`
`6661`	`6661`	`static char *`
`6662`	`6662`	`tmx_m_zone(union DateData *x)`
`6663`	`6663`	`{`
`6664`		`- return RSTRING_PTR(m_zone(x));`
	`6664`	`+ VALUE zone = m_zone(x);`
	`6665`	`+ /* TODO: fix potential dangling pointer */`
	`6666`	`+ return RSTRING_PTR(zone);`
`6665`	`6667`	`}`
`6666`	`6668`
`6667`	`6669`	`static const struct tmx_funcs tmx_funcs = {`